Re: [PATCH v8 07/10] powerpc/perf: PMU functions for Core IMC and hotplugging

From	Stewart Smith <stewart@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 07/10] powerpc/perf: PMU functions for Core IMC and hotplugging
Date	2017-05-17 10:00 +0200
Message-ID	<tI22e-fo-7@gated-at.bofh.it> (permalink)
References	<tDpVv-4CY-1@gated-at.bofh.it> <tDpVw-4CY-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Anju T Sudhakar <anju@linux.vnet.ibm.com> writes:
> --- a/arch/powerpc/include/asm/imc-pmu.h
> +++ b/arch/powerpc/include/asm/imc-pmu.h
> @@ -24,6 +24,7 @@
>   */
>  #define IMC_MAX_CHIPS			32
>  #define IMC_MAX_PMUS			32
> +#define IMC_MAX_CORES			32
>
>  /*
>   * This macro is used for memory buffer allocation of
> @@ -38,6 +39,11 @@
>  #define IMC_NEST_MAX_PAGES		64
>
>  /*
> + * IMC Core engine expects 8K bytes of memory for counter collection.
> + */
> +#define IMC_CORE_COUNTER_MEM		8192

Any reason for this not to be in the device tree?

This is the size of memory that Linux needs to give OPAL, so the size of
that should probably come from OPAL rather than Linux.

Otherwise, if in the future, we had a counter with an offset greater
than 8192 in, we'd have no way to detect that and we'd fail silently by
overwriting memory.

-- 
Stewart Smith
OPAL Architect, IBM.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v8 07/10] powerpc/perf: PMU functions for Core IMC and hotplugging Stewart Smith <stewart@linux.vnet.ibm.com> - 2017-05-17 10:00 +0200

csiph-web