Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1638607

Re: [PATCH] wcn36xx: Close SMD channel on device removal

Show all headers | View raw

On 5/10/2017 1:03 AM, Bjorn Andersson wrote:
> On Mon 08 May 23:17 PDT 2017, Kalle Valo wrote:
> 
>> Bjorn Andersson <bjorn.andersson@linaro.org> writes:
>>
>>> The SMD channel is not the primary WCNSS channel and must explicitly be
>>> closed as the device is removed, or the channel will already by open on
>>> a subsequent probe call in e.g. the case of reloading the kernel module.
>>>
>>> This issue was introduced because I simplified the underlying SMD
>>> implementation while the SMD adaptions of the driver sat on the mailing
>>> list, but missed to update these patches. The patch does however only
>>> apply back to the transition to rpmsg, hence the limited Fixes.
>>>
>>> Fixes: 5052de8deff5 ("soc: qcom: smd: Transition client drivers from smd to rpmsg")
>>> Reported-by: Eyal Ilsar <c_eilsar@qti.qualcomm.com>
>>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>>
>> As this is a regression I'll queue this to 4.12.
>>
> 
> Thanks.
> 
>> But if this is an older bug (didn't quite understand your description
>> though) should there be a separate patch for stable releases?
>>
> 
> AFAICT this never worked, as it seems I did the rework in SMD while we
> tried to figure out the dependency issues we had with moving to SMD. So
> v4.9 through v4.11 has SMD support - with this bug.
> 
> How do I proceed, do you want me to write up a fix for stable@? Do I
> send that out as an ordinary patch?

If the patch applies cleanly on branches linux-4.9.y through 
linux-4.11.y in the stable repository you can go for '--- Option 1 ---' 
as described in <linux-repo>/Documentation/stable_kernel_rules.txt.

Regards,
Arend

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] wcn36xx: Close SMD channel on device removal Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-09 06:40 +0200
  Re: [PATCH] wcn36xx: Close SMD channel on device removal Kalle Valo <kvalo@codeaurora.org> - 2017-05-09 08:20 +0200
    Re: [PATCH] wcn36xx: Close SMD channel on device removal Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-10 01:10 +0200
      Re: [PATCH] wcn36xx: Close SMD channel on device removal Arend van Spriel <arend.vanspriel@broadcom.com> - 2017-05-10 09:30 +0200
        Re: [PATCH] wcn36xx: Close SMD channel on device removal Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-10 20:00 +0200
          Re: [PATCH] wcn36xx: Close SMD channel on device removal Kalle Valo <kvalo@codeaurora.org> - 2017-05-11 14:20 +0200

csiph-web