Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637860

[PATCH] wcn36xx: Close SMD channel on device removal

Show all headers | View raw

The SMD channel is not the primary WCNSS channel and must explicitly be
closed as the device is removed, or the channel will already by open on
a subsequent probe call in e.g. the case of reloading the kernel module.

This issue was introduced because I simplified the underlying SMD
implementation while the SMD adaptions of the driver sat on the mailing
list, but missed to update these patches. The patch does however only
apply back to the transition to rpmsg, hence the limited Fixes.

Fixes: 5052de8deff5 ("soc: qcom: smd: Transition client drivers from smd to rpmsg")
Reported-by: Eyal Ilsar <c_eilsar@qti.qualcomm.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 drivers/net/wireless/ath/wcn36xx/main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index d5e993dc9b23..517a315e259b 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -1271,6 +1271,8 @@ static int wcn36xx_remove(struct platform_device *pdev)
 	qcom_smem_state_put(wcn->tx_enable_state);
 	qcom_smem_state_put(wcn->tx_rings_empty_state);
 
+	rpmsg_destroy_ept(wcn->smd_channel);
+
 	iounmap(wcn->dxe_base);
 	iounmap(wcn->ccu_base);
 
-- 
2.12.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] wcn36xx: Close SMD channel on device removal Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-09 06:40 +0200
  Re: [PATCH] wcn36xx: Close SMD channel on device removal Kalle Valo <kvalo@codeaurora.org> - 2017-05-09 08:20 +0200
    Re: [PATCH] wcn36xx: Close SMD channel on device removal Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-10 01:10 +0200
      Re: [PATCH] wcn36xx: Close SMD channel on device removal Arend van Spriel <arend.vanspriel@broadcom.com> - 2017-05-10 09:30 +0200
        Re: [PATCH] wcn36xx: Close SMD channel on device removal Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-05-10 20:00 +0200
          Re: [PATCH] wcn36xx: Close SMD channel on device removal Kalle Valo <kvalo@codeaurora.org> - 2017-05-11 14:20 +0200

csiph-web