Re: [PATCH] net: fec: select queue depending on VLAN priority

From	Stefan Agner <stefan@agner.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: fec: select queue depending on VLAN priority
Date	2017-05-10 07:00 +0200
Message-ID	<tFrTb-4oD-1@gated-at.bofh.it> (permalink)
References	<tF62l-5K4-1@gated-at.bofh.it> <tFdwS-2iO-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017-05-09 06:39, David Miller wrote:
> From: Stefan Agner <stefan@agner.ch>
> Date: Mon,  8 May 2017 22:37:08 -0700
> 
>> Since the addition of the multi queue code with commit 59d0f7465644
>> ("net: fec: init multi queue date structure") the queue selection
>> has been handelt by the default transmit queue selection
>> implementation which tries to evenly distribute the traffic across
>> all available queues. This selection presumes that the queues are
>> using an equal priority, however, the queues 1 and 2 are actually
>> of higher priority (the classification of the queues is enabled in
>> fec_enet_enable_ring).
>>
>> This can lead to net scheduler warnings and continuous TX ring
>> dumps when exercising the system with iperf.
>>
>> Use only queue 0 for all common traffic (no VLAN and P802.1p
>> priority 0 and 1) and route level 2-7 through queue 1 and 2.
>>
>> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
>> Fixes: 59d0f7465644 ("net: fec: init multi queue date structure")
> 
> If the queues are used for prioritization, and it does not have
> multiple normal priority level queues, multiqueue is not what the
> driver should have implemented.

As Andy mentioned, there is also a round-robin mode. I'll try that.

What would be the proper way to use the prioritized queues?

--
Stefan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: fec: select queue depending on VLAN priority Stefan Agner <stefan@agner.ch> - 2017-05-09 07:40 +0200
  Re: [PATCH] net: fec: select queue depending on VLAN priority Andrew Lunn <andrew@lunn.ch> - 2017-05-09 14:20 +0200
  Re: [PATCH] net: fec: select queue depending on VLAN priority David Miller <davem@davemloft.net> - 2017-05-09 15:40 +0200
    RE: [PATCH] net: fec: select queue depending on VLAN priority Andy Duan <fugang.duan@nxp.com> - 2017-05-10 04:50 +0200
      Re: [PATCH] net: fec: select queue depending on VLAN priority Stefan Agner <stefan@agner.ch> - 2017-05-11 06:10 +0200
        RE: [PATCH] net: fec: select queue depending on VLAN priority Andy Duan <fugang.duan@nxp.com> - 2017-05-11 06:50 +0200
    Re: [PATCH] net: fec: select queue depending on VLAN priority Stefan Agner <stefan@agner.ch> - 2017-05-10 07:00 +0200

csiph-web