Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1638076

Re: [PATCH] net: fec: select queue depending on VLAN priority

Show all headers | View raw

On Mon, May 08, 2017 at 10:37:08PM -0700, Stefan Agner wrote:
> Since the addition of the multi queue code with commit 59d0f7465644
> ("net: fec: init multi queue date structure") the queue selection
> has been handelt by the default transmit queue selection
> implementation which tries to evenly distribute the traffic across
> all available queues. This selection presumes that the queues are
> using an equal priority, however, the queues 1 and 2 are actually
> of higher priority (the classification of the queues is enabled in
> fec_enet_enable_ring).
> 
> This can lead to net scheduler warnings and continuous TX ring
> dumps when exercising the system with iperf.
> 
> Use only queue 0 for all common traffic (no VLAN and P802.1p
> priority 0 and 1) and route level 2-7 through queue 1 and 2.

Hi Stefan

Did you try:

vconfig set_egress_map eth0.42 0 7
ip addr add 10.42.42.42/24 eth0.42
iperf -c 10.42.42.1

i.e. send a continuous stream on one of the higher priority queues.

From what was said earlier in this thread, isn't queue 0 going to be
starved? As well as this patch, don't we also need some default
bandwidth allocations to the queues to ensure queue 0 does get some
bandwidth?

	Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: fec: select queue depending on VLAN priority Stefan Agner <stefan@agner.ch> - 2017-05-09 07:40 +0200
  Re: [PATCH] net: fec: select queue depending on VLAN priority Andrew Lunn <andrew@lunn.ch> - 2017-05-09 14:20 +0200
  Re: [PATCH] net: fec: select queue depending on VLAN priority David Miller <davem@davemloft.net> - 2017-05-09 15:40 +0200
    RE: [PATCH] net: fec: select queue depending on VLAN priority Andy Duan <fugang.duan@nxp.com> - 2017-05-10 04:50 +0200
      Re: [PATCH] net: fec: select queue depending on VLAN priority Stefan Agner <stefan@agner.ch> - 2017-05-11 06:10 +0200
        RE: [PATCH] net: fec: select queue depending on VLAN priority Andy Duan <fugang.duan@nxp.com> - 2017-05-11 06:50 +0200
    Re: [PATCH] net: fec: select queue depending on VLAN priority Stefan Agner <stefan@agner.ch> - 2017-05-10 07:00 +0200

csiph-web