Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1638466
| From | Henrique de Moraes Holschuh <hmh@hmh.eng.br> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string literals back |
| Date | 2017-05-10 02:30 +0200 |
| Message-ID | <tFnFU-MR-7@gated-at.bofh.it> (permalink) |
| References | <tFe9A-2OU-13@gated-at.bofh.it> <tFejg-2TS-11@gated-at.bofh.it> <tFgXM-4Lx-3@gated-at.bofh.it> <tFhh8-4SQ-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, May 9, 2017, at 14:33, Andy Shevchenko wrote:
> On Tue, 2017-05-09 at 14:10 -0300, Henrique de Moraes Holschuh wrote:
> > > While here, print negative error without changing a sign as it is a
> > > common pattern in the kernel.
> >
> > A separate patch for this would be better: it would be easier to
> > actually check that no functional changes crept in by mistake.
>
> It doesn't make sense to me. It would touch same lines of code I do
> already here and it's only one place, see below.
I had to go line-by-line looking for the darn thing, instead of just
compiling before-and-after and checking for an unchanged object file.
> > > rc = fan_set_enable();
> > > if (rc < 0) {
> > > - pr_err("fan watchdog: error %d while enabling fan,
> > > "
> > > - "will try again later...\n", -rc);
> > > + pr_err("fan watchdog: error %d while enabling fan,
> > > will try again later...\n",
> > > + rc);
Yeah. This one. I don't have a problem with this change at all (I acked
it), but it took some effort to find the nail in the hailstack.
--
Henrique Holschuh
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v1 1/3] platform/x86: thinkpad_acpi: Make logic straight in hotkey_exit() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-09 16:20 +0200
[PATCH v1 3/3] platform/x86: thinkpad_acpi: Add a comment about 0 in module_param_call() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-09 16:30 +0200
Re: [PATCH v1 3/3] platform/x86: thinkpad_acpi: Add a comment about 0 in module_param_call() Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-05-09 19:10 +0200
[PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string literals back Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-09 16:30 +0200
Re: [PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string literals back Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-05-09 19:20 +0200
Re: [PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string literals back Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-09 19:40 +0200
Re: [PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string literals back Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-05-10 02:30 +0200
Re: [PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string literals back Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-10 13:00 +0200
Re: [PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string literals back Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-05-10 15:30 +0200
Re: [PATCH v1 1/3] platform/x86: thinkpad_acpi: Make logic straight in hotkey_exit() Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-05-09 19:10 +0200
Re: [PATCH v1 1/3] platform/x86: thinkpad_acpi: Make logic straight in hotkey_exit() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-09 19:40 +0200
csiph-web