Re: [PATCH v1 3/3] platform/x86: thinkpad_acpi: Add a comment about 0 in module_param_call()

From	Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 3/3] platform/x86: thinkpad_acpi: Add a comment about 0 in module_param_call()
Date	2017-05-09 19:10 +0200
Message-ID	<tFgO5-4HS-13@gated-at.bofh.it> (permalink)
References	<tFe9A-2OU-13@gated-at.bofh.it> <tFejg-2TS-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 09 May 2017, Andy Shevchenko wrote:
> As per discussion [1] there are only few users of module_param_call() in
> kernel which prevent to read module parameters back.
> 
> It thinkpad_acpi driver there is even no method do so. Thus, for now,
> add just a comment to explain why 0 is used as permissions in
> module_param_call().
> 
> [1]: https://patchwork.ozlabs.org/patch/713245/
> 
> Cc: Richard Weinberger <richard.weinberger@gmail.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

> ---
>  drivers/platform/x86/thinkpad_acpi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index e6fbb2579dd9..f5bc888b2ef4 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -9663,6 +9663,7 @@ module_param_named(enable, alsa_enable, bool, 0444);
>  MODULE_PARM_DESC(enable, "Enable the ALSA interface for the ACPI EC Mixer");
>  #endif /* CONFIG_THINKPAD_ACPI_ALSA_SUPPORT */
>  
> +/* The module parameter can't be read back, that's why 0 is used here */
>  #define TPACPI_PARAM(feature) \
>  	module_param_call(feature, set_ibm_param, NULL, NULL, 0); \
>  	MODULE_PARM_DESC(feature, "Simulates thinkpad-acpi procfs command at module load, see documentation")

-- 
  Henrique Holschuh

  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot

Thread

[PATCH v1 1/3] platform/x86: thinkpad_acpi: Make logic straight in hotkey_exit() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-09 16:20 +0200
  [PATCH v1 3/3] platform/x86: thinkpad_acpi: Add a comment about 0 in module_param_call() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-09 16:30 +0200
    Re: [PATCH v1 3/3] platform/x86: thinkpad_acpi: Add a comment about  0 in module_param_call() Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-05-09 19:10 +0200
  [PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string literals back Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-09 16:30 +0200
    Re: [PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string literals  back Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-05-09 19:20 +0200
      Re: [PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string  literals back Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-09 19:40 +0200
        Re: [PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string literals  back Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-05-10 02:30 +0200
          Re: [PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string  literals back Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-10 13:00 +0200
            Re: [PATCH v1 2/3] platform/x86: thinkpad_acpi: Join string literals  back Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-05-10 15:30 +0200
  Re: [PATCH v1 1/3] platform/x86: thinkpad_acpi: Make logic straight  in hotkey_exit() Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-05-09 19:10 +0200
    Re: [PATCH v1 1/3] platform/x86: thinkpad_acpi: Make logic straight  in hotkey_exit() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-09 19:40 +0200

csiph-web