Re: [PATCH] perf, tools, script: Allow adding and removing fields

From	Andi Kleen <andi@firstfloor.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf, tools, script: Allow adding and removing fields
Date	2017-05-09 16:40 +0200
Message-ID	<tFesW-2Ya-13@gated-at.bofh.it> (permalink)
References	<tETHR-6g8-29@gated-at.bofh.it> <tFcr8-1Fu-17@gated-at.bofh.it> <tFcAP-1J6-31@gated-at.bofh.it> <tFdGx-2mx-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 09, 2017 at 03:45:03PM +0200, Jiri Olsa wrote:
> On Tue, May 09, 2017 at 05:29:24AM -0700, Andi Kleen wrote:
> > > so the -F option for 'type:' does not have default set,
> > > and it looks like the +- don't make sense there:
> > 
> > hw:+comm is just equivalent to hw:comm
> > 
> > Seems fine to me?
> > 
> > hw:-comm won't do anything, but I guess that's expected.
> > 
> > Don't see any need to change this?
> 
> why did you add it in the first place then?

You mean the Don't override defaults check in the hw types specified case?

I guess it could be removed yes.

-Andi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] perf, tools, script: Allow adding and removing fields Andi Kleen <andi@firstfloor.org> - 2017-05-08 18:30 +0200
  Re: [PATCH] perf, tools, script: Allow adding and removing fields Jiri Olsa <jolsa@redhat.com> - 2017-05-09 14:30 +0200
    Re: [PATCH] perf, tools, script: Allow adding and removing fields Andi Kleen <ak@linux.intel.com> - 2017-05-09 14:40 +0200
      Re: [PATCH] perf, tools, script: Allow adding and removing fields Jiri Olsa <jolsa@redhat.com> - 2017-05-09 15:50 +0200
        Re: [PATCH] perf, tools, script: Allow adding and removing fields Andi Kleen <andi@firstfloor.org> - 2017-05-09 16:40 +0200

csiph-web