Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions
Date	2017-05-11 16:50 +0200
Message-ID	<tFXzI-7Av-11@gated-at.bofh.it> (permalink)
References	<tDcvf-4cE-3@gated-at.bofh.it> <tFWX0-7l8-25@gated-at.bofh.it> <tFXzI-7Av-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Thu, May 11, 2017 at 03:20:58PM +0100, Andre Przywara wrote:
> > Tejun, do I read your comments on the patch as an ACK?
> 
> Tejun and I were wondering why we need this "create an array with the
> indices" in the first place. If we can just call radix_tree_delete()
> directly from the radix_tree_for_each_slot() loop, we can have a much
> better fix (omitting the memory allocation at all)

Yeah, it doesn't make sense to allocate to destroy a radix tree.  It'd
be much better to cleanup the code so that it doesn't need allocation
in the first place.

Thanks.

-- 
tejun

Thread

[PATCH] pinctrl: use non-devm kmalloc versions for free functions Andre Przywara <andre.przywara@arm.com> - 2017-05-04 02:10 +0200
  Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 14:10 +0200
    Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions Tejun Heo <tj@kernel.org> - 2017-05-04 18:10 +0200
      Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions André Przywara <andre.przywara@arm.com> - 2017-05-05 02:50 +0200
      Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-05 22:00 +0200
        Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions Tejun Heo <tj@kernel.org> - 2017-05-06 00:00 +0200
  Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions Linus Walleij <linus.walleij@linaro.org> - 2017-05-11 16:10 +0200
    Re: [linux-sunxi] Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions Icenowy Zheng <icenowy@aosc.io> - 2017-05-11 16:20 +0200
    Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions Tejun Heo <tj@kernel.org> - 2017-05-11 16:50 +0200
    Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions Andre Przywara <andre.przywara@arm.com> - 2017-05-11 17:30 +0200
      Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions Linus Walleij <linus.walleij@linaro.org> - 2017-05-12 11:30 +0200
        Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions Tony Lindgren <tony@atomide.com> - 2017-05-12 17:40 +0200
          Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions Tony Lindgren <tony@atomide.com> - 2017-05-12 19:20 +0200
            Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions André Przywara <andre.przywara@arm.com> - 2017-05-13 02:30 +0200
            Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions Linus Walleij <linus.walleij@linaro.org> - 2017-05-22 17:50 +0200

csiph-web