Re: net/key: slab-out-of-bounds in pfkey_compile_policy

From	Steffen Klassert <steffen.klassert@secunet.com>
Newsgroups	linux.kernel
Subject	Re: net/key: slab-out-of-bounds in pfkey_compile_policy
Date	2017-05-08 14:00 +0200
Message-ID	<tEPux-3tj-5@gated-at.bofh.it> (permalink)
References	<tCJ9T-LW-11@gated-at.bofh.it> <tDHz3-8aB-9@gated-at.bofh.it> <tDKnf-1Cl-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 05, 2017 at 02:18:01PM +0200, Andrey Konovalov wrote:
> On Fri, May 5, 2017 at 11:11 AM, Steffen Klassert
> <steffen.klassert@secunet.com> wrote:
> > On Tue, May 02, 2017 at 06:45:03PM +0200, Andrey Konovalov wrote:
> >> Hi,
> >>
> >> I've got the following error report while fuzzing the kernel with syzkaller.
> >>
> >> On commit d3b5d35290d729a2518af00feca867385a1b08fa (4.11).
> >>
> >> A reproducer and .config are attached.
> >>
> >> ==================================================================
> >> BUG: KASAN: slab-out-of-bounds in pfkey_compile_policy+0x8e6/0xd40 at
> >> addr ffff88006701f798
> >> Read of size 1280 by task a.out/4181
> >
> >
> > This bug was introduced twelve years ago...
> >
> > This patch is based just on code review, I don't have an option to
> > function test this. But I see that we now exit with -EINVAL before the
> > memcpy that causes the slab-out-of-bounds when using your reproducer,
> > so it should at least fix the bug.
> 
> Hi Steffen,
> 
> This patch fixes the issue for me.
> 
> Thanks!
> 
> Tested-by: Andrey Konovalov <andreyknvl@google.com>

Patch is now applied to the ipsec tree.
Thanks for reporting and testing!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

net/key: slab-out-of-bounds in pfkey_compile_policy Andrey Konovalov <andreyknvl@google.com> - 2017-05-02 18:50 +0200
  Re: net/key: slab-out-of-bounds in pfkey_compile_policy Steffen Klassert <steffen.klassert@secunet.com> - 2017-05-05 11:20 +0200
    Re: net/key: slab-out-of-bounds in pfkey_compile_policy Andrey Konovalov <andreyknvl@google.com> - 2017-05-05 14:20 +0200
      Re: net/key: slab-out-of-bounds in pfkey_compile_policy Steffen Klassert <steffen.klassert@secunet.com> - 2017-05-08 14:00 +0200

csiph-web