Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues
Date	2017-05-08 14:00 +0200
Message-ID	<tEPux-3tj-3@gated-at.bofh.it> (permalink)
References	(4 earlier) <tENCp-2jk-1@gated-at.bofh.it> <tENVM-2EL-9@gated-at.bofh.it> <tEOoO-2O9-17@gated-at.bofh.it> <tEPbb-3lD-3@gated-at.bofh.it> <tEPkS-3q9-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 8, 2017 at 2:40 PM, Joao Pinto <Joao.Pinto@synopsys.com> wrote:
> Às 12:34 PM de 5/8/2017, Andy Shevchenko escreveu:
>> On Mon, May 8, 2017 at 1:42 PM, Joao Pinto <Joao.Pinto@synopsys.com> wrote:
>>> Às 11:12 AM de 5/8/2017, Andy Shevchenko escreveu:
>>>> On Mon, May 8, 2017 at 12:54 PM, Joao Pinto <Joao.Pinto@synopsys.com> wrote:
>>>>> Às 10:36 AM de 5/8/2017, Andy Shevchenko escreveu:

>>
>> [   44.374161] stmmac_dvr_probe <<< 0 0
>>
>
> Ok, so this is the cause of the problem. The driver is geting 0 for real RX and
> TX queues.
>
> Your setup uses standard DT parsing from stmmac_platform or a custom one?
>
> If you are using stmmac_probe_config_dt():
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c#n363
>
> You will find a function named stmmac_mtl_setup() being called:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c#n492
>
> In this function, the number of RX and TX queues is being set to 1 by default.

Ah-ha, now I know how it's happened.
You forget to update all setup() hooks in PCI bus driver :-)

I will prepare a fix.
Just tell me should I put Fixes tag or not? And if yes, what commit
should I refer to?

-- 
With Best Regards,
Andy Shevchenko

Thread

Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config  for multiple queues Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-08 09:00 +0200
  Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config  for multiple queues Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-08 11:40 +0200
    Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config  for multiple queues Joao Pinto <Joao.Pinto@synopsys.com> - 2017-05-08 12:00 +0200
      Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config  for multiple queues Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-08 12:20 +0200
        Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config  for multiple queues Joao Pinto <Joao.Pinto@synopsys.com> - 2017-05-08 12:50 +0200
          Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config  for multiple queues Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-08 13:40 +0200
            Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config  for multiple queues Joao Pinto <Joao.Pinto@synopsys.com> - 2017-05-08 13:50 +0200
              Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config  for multiple queues Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-08 14:00 +0200
                Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config  for multiple queues Joao Pinto <Joao.Pinto@synopsys.com> - 2017-05-08 14:10 +0200
                Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config  for multiple queues Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-08 14:40 +0200

csiph-web