Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1637335
| Path | csiph.com!news.redatomik.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Tobias Regnery <tobias.regnery@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4 |
| Date | Mon, 08 May 2017 11:50:01 +0200 |
| Message-ID | <tENsJ-2fC-9@gated-at.bofh.it> (permalink) |
| X-Original-To | marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=k2tRrTXT306TmCZvXX4kxTGsqv/KB8utGeAsb1M7QCE=; b=p9FsW9LCCFVweL5Wlgwy7MJB6tMMLOVHoOn5WGlW4n8g4j3hqJyZpF+ODfnqpylpW6 nnUADDSUqRsaWGhwlsazw/PfzjghnsSboJ1dAv629EfETK+tU04ok/prIoXvor05RhK8 7bNjmUlSmxKcj5agvE2mcsoSlQneQ+qUL7YI8ecirlaluiJWdj0Z/Nh+dSdASAdjS0eO ZiNYDlF1VgYHR+2DS4z7+dUIydWbhJXBeMipkK+14gqfdQwZj2q7HcjK/dak7abTRZlx njBqHe8EDamnnO3vo3WWH/NdW+U6Fy7H9QpRlMLiog8Ay7gvRCRc8L22AngCRdoPthAy IwAg== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=k2tRrTXT306TmCZvXX4kxTGsqv/KB8utGeAsb1M7QCE=; b=ABkcK3ejuzd9ZL1Ge1nskZFWiBA2k9fkQcbBY9rYxB9V2Eeqk55ue6P2iGtQqwJByL 9mjcbmS6JIMz5UtGeJnaytlUKknqrmS3yzYVD10lIkRPLAwlqrs+bWQS9lJrh0mbQYmI Rc/EukUUsOIsmWV+4EeVAOpLUCx5v4VeOvOtql9/2XbVfVh+ycPYAQZ5WGLhk9liEHp6 /GKJQpYcHqcZRCzsbwOWAuDFcc12+z5+n+nbULILFFPmZ4f69MNvxGetQtNexpN8OGQs S0UbAHtIjdcaVuW0NLXYbx79n+O81Vt/H0F6EV8J4d2KcX8wan9GJ/PYu5dijKBOrK8H WEKw== |
| X-Gm-Message-State | AODbwcBPa0r39ruRM2H/QTj3j5z4NO/DyRCPbl3m4/WB2S1iuqB0sKdb 6JnwzujUwOU3Pg== |
| X-Received | by 10.28.207.201 with SMTP id f192mr5602234wmg.79.1494236569259; Mon, 08 May 2017 02:42:49 -0700 (PDT) |
| X-Mailer | git-send-email 2.11.0 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 30 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | sre@kernel.org, Tobias Regnery <tobias.regnery@gmail.com> |
| X-Original-Date | Mon, 8 May 2017 11:39:11 +0200 |
| X-Original-Message-ID | <20170508093911.25228-1-tobias.regnery@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1637335 |
Show key headers only | View raw
We see the following build failure with CONFIG_BT_HCIUART_NOKIA=y and
CONFIG_BT_HCIUART_H4=n:
drivers/bluetooth/hci_nokia.c: In function 'nokia_recv':
drivers/bluetooth/hci_nokia.c:644:18: error: implicit declaration of function 'h4_recv_buf' [-Werror=implicit-function-declaration]
...
Fix this by selecting the BT_HCIUART_H4 symbol like all the other users
of the protocoll.
Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
drivers/bluetooth/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index e5fd24d90b0a..35952a94875e 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -97,6 +97,7 @@ config BT_HCIUART_NOKIA
depends on BT_HCIUART
depends on BT_HCIUART_SERDEV
depends on PM
+ select BT_HCIUART_H4
help
Nokia H4+ is serial protocol for communication between Bluetooth
device and host. This protocol is required for Bluetooth devices
--
2.11.0
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4 Tobias Regnery <tobias.regnery@gmail.com> - 2017-05-08 11:50 +0200 Re: [PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4 Sebastian Reichel <sre@kernel.org> - 2017-05-08 20:30 +0200
csiph-web