Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1637335 > unrolled thread
| Started by | Tobias Regnery <tobias.regnery@gmail.com> |
|---|---|
| First post | 2017-05-08 11:50 +0200 |
| Last post | 2017-05-08 20:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4 Tobias Regnery <tobias.regnery@gmail.com> - 2017-05-08 11:50 +0200
Re: [PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4 Sebastian Reichel <sre@kernel.org> - 2017-05-08 20:30 +0200
| From | Tobias Regnery <tobias.regnery@gmail.com> |
|---|---|
| Date | 2017-05-08 11:50 +0200 |
| Subject | [PATCH] Bluetooth: hci_nokia: select BT_HCIUART_H4 |
| Message-ID | <tENsJ-2fC-9@gated-at.bofh.it> |
We see the following build failure with CONFIG_BT_HCIUART_NOKIA=y and
CONFIG_BT_HCIUART_H4=n:
drivers/bluetooth/hci_nokia.c: In function 'nokia_recv':
drivers/bluetooth/hci_nokia.c:644:18: error: implicit declaration of function 'h4_recv_buf' [-Werror=implicit-function-declaration]
...
Fix this by selecting the BT_HCIUART_H4 symbol like all the other users
of the protocoll.
Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
drivers/bluetooth/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index e5fd24d90b0a..35952a94875e 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -97,6 +97,7 @@ config BT_HCIUART_NOKIA
depends on BT_HCIUART
depends on BT_HCIUART_SERDEV
depends on PM
+ select BT_HCIUART_H4
help
Nokia H4+ is serial protocol for communication between Bluetooth
device and host. This protocol is required for Bluetooth devices
--
2.11.0
[toc] | [next] | [standalone]
| From | Sebastian Reichel <sre@kernel.org> |
|---|---|
| Date | 2017-05-08 20:30 +0200 |
| Message-ID | <tEVzY-7rS-7@gated-at.bofh.it> |
| In reply to | #1637335 |
[Multipart message — attachments visible in raw view] — view raw
Hi,
On Mon, May 08, 2017 at 11:39:11AM +0200, Tobias Regnery wrote:
> We see the following build failure with CONFIG_BT_HCIUART_NOKIA=y and
> CONFIG_BT_HCIUART_H4=n:
>
> drivers/bluetooth/hci_nokia.c: In function 'nokia_recv':
> drivers/bluetooth/hci_nokia.c:644:18: error: implicit declaration of function 'h4_recv_buf' [-Werror=implicit-function-declaration]
> ...
>
> Fix this by selecting the BT_HCIUART_H4 symbol like all the other users
> of the protocoll.
>
> Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
Reviewed-by: Sebastian Reichel <sre@kernel.org>
-- Sebastian
> ---
> drivers/bluetooth/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index e5fd24d90b0a..35952a94875e 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -97,6 +97,7 @@ config BT_HCIUART_NOKIA
> depends on BT_HCIUART
> depends on BT_HCIUART_SERDEV
> depends on PM
> + select BT_HCIUART_H4
> help
> Nokia H4+ is serial protocol for communication between Bluetooth
> device and host. This protocol is required for Bluetooth devices
> --
> 2.11.0
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web