Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637169

Re: Resizeable PCI BAR support v5

Show all headers | View raw

On Thu, May 4, 2017 at 12:31 PM, Christian König
<deathsimple@vodafone.de> wrote:
> Hi everyone,
>
> this is the fifth incarnation of this set of patches. It enables device
> drivers to resize and most likely also relocate the PCI BAR of devices
> they manage to allow the CPU to access all of the device local memory at once.
>
> This is very useful for GFX device drivers where the default PCI BAR is only
> about 256MB in size for compatibility reasons, but the device easily have
> multiple gigabyte of local memory.
>
> Noteable changed compared to v4:
> 1. Patch #1 is new and a minor cleanup to the PCI code.
> 2. Some more helpers added to patch #2
> 3. We now print a note to syslog before releasing resources.
> 4. Add defines for registers and bits used to add new root hub window.
>
> I've addressed mostly every review comment I've got so far and it looks like we
> are getting closer to landing this. Any more suggestions/hints how we could
> improve the patchset would be very welcome.
>

Thanks for an update.

I'm going to comment individual patches.

Just for the future, please use versioning in the patches themselves
(hint: -vX to git-format-patch).

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Resizeable PCI BAR support v5 Christian König <deathsimple@vodafone.de> - 2017-05-04 11:40 +0200
  [PATCH 2/5] PCI: add resizeable BAR infrastructure v5 Christian König <deathsimple@vodafone.de> - 2017-05-04 11:40 +0200
    Re: [PATCH 2/5] PCI: add resizeable BAR infrastructure v5 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-08 00:40 +0200
  [PATCH 3/5] PCI: add functionality for resizing resources v4 Christian König <deathsimple@vodafone.de> - 2017-05-04 11:40 +0200
    Re: [PATCH 3/5] PCI: add functionality for resizing resources v4 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-08 01:20 +0200
  [PATCH 5/5] drm/amdgpu: resize VRAM BAR for CPU access v2 Christian König <deathsimple@vodafone.de> - 2017-05-04 11:40 +0200
  [PATCH 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v3 Christian König <deathsimple@vodafone.de> - 2017-05-04 11:40 +0200
    Re: [PATCH 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models  30h-3fh) Processors v3 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-08 01:50 +0200
  [PATCH 1/5] PCI: add a define for the PCI resource type mask Christian König <deathsimple@vodafone.de> - 2017-05-04 11:40 +0200
    Re: [PATCH 1/5] PCI: add a define for the PCI resource type mask Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-08 00:20 +0200
  Re: Resizeable PCI BAR support v5 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-08 02:00 +0200

csiph-web