Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637028

[PATCH v3] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

Show all headers | View raw

A kernel cloned from git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and built with the latest RTL8723BS driver included (CONFIG_RTL8723BS=m) fails when booting on an Intel Atom device with the RTL8723BS wifi chipset due to an error in drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c.

The kernel when booted with Ubuntu 17.04 results in an unusable system however with the following patch booting is successful and the system is usable. The patch and kernel builds have been tested against on an Intel Compute Stick (STCK1A32WFC model).

This version of the patch (version 3) has tabs rather than spaces and no wrap around. The patch has received one review:

Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,
Ian

From: Ian W Morrison <linuxium@linuxium.com.au>
Date: Fri, 28 Apr 2017 02:20:38 +1000
Subject: [PATCH] staging: rtl8723bs: remove a call to kfree in
 os_dep/ioctl_cfg80211.c

Signed-off-by: Ian W Morrison <linuxium@linuxium.com.au>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index f17f4fb..2ee9df5 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -3527,7 +3527,6 @@ int rtw_wdev_alloc(struct adapter *padapter, struct device *dev)
 		pwdev_priv->power_mgmt = true;
 	else
 		pwdev_priv->power_mgmt = false;
-	kfree((u8 *)wdev);
 
 	return ret;
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] staging: rtl8723bs: remove re-positioned call to kfree in  os_dep/ioctl_cfg80211.c Ian W MORRISON <ianwmorrison@gmail.com> - 2017-05-07 23:50 +0200
  [PATCH v4] staging: rtl8723bs: remove re-positioned call to kfree in  os_dep/ioctl_cfg80211.c Ian W MORRISON <ianwmorrison@gmail.com> - 2017-05-08 00:00 +0200
    [PATCH v5] staging: rtl8723bs: remove re-positioned call to kfree in  os_dep/ioctl_cfg80211.c Ian W MORRISON <ianwmorrison@gmail.com> - 2017-05-08 00:20 +0200
      [PATCH v6] staging: rtl8723bs: remove re-positioned call to kfree in  os_dep/ioctl_cfg80211.c Ian W MORRISON <ianwmorrison@gmail.com> - 2017-05-08 15:50 +0200
      Re: [PATCH v5] staging: rtl8723bs: remove re-positioned call to kfree  in os_dep/ioctl_cfg80211.c Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-08 16:50 +0200

csiph-web