Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1637094

[PATCH v5] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

From Ian W MORRISON <ianwmorrison@gmail.com>
Newsgroups linux.kernel
Subject [PATCH v5] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c
Date 2017-05-08 00:20 +0200
Message-ID <tECGZ-3sL-1@gated-at.bofh.it> (permalink)
References <tECe0-30b-57@gated-at.bofh.it> <tECnF-34t-49@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


A kernel cloned from 
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and 
built with the latest RTL8723BS driver included (CONFIG_RTL8723BS=m) 
fails when booting on an Intel Atom device with the RTL8723BS wifi 
chipset due to an error in 
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c.

The kernel when booted with Ubuntu 17.04 results in an unusable system 
however with the following patch booting is successful and the system 
is usable. The patch and kernel builds have been tested against on an 
Intel Compute Stick (STCK1A32WFC model).

This version of the patch (version 5) has tabs rather than spaces, no 
wrap around, a changelog and a sign-off email. 

Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Ian W Morrison <ianwmorrison@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index f17f4fb..2ee9df5 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -3527,7 +3527,6 @@ int rtw_wdev_alloc(struct adapter *padapter, struct device *dev)
 		pwdev_priv->power_mgmt = true;
 	else
 		pwdev_priv->power_mgmt = false;
-	kfree((u8 *)wdev);
 
 	return ret;
 
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3] staging: rtl8723bs: remove re-positioned call to kfree in  os_dep/ioctl_cfg80211.c Ian W MORRISON <ianwmorrison@gmail.com> - 2017-05-07 23:50 +0200
  [PATCH v4] staging: rtl8723bs: remove re-positioned call to kfree in  os_dep/ioctl_cfg80211.c Ian W MORRISON <ianwmorrison@gmail.com> - 2017-05-08 00:00 +0200
    [PATCH v5] staging: rtl8723bs: remove re-positioned call to kfree in  os_dep/ioctl_cfg80211.c Ian W MORRISON <ianwmorrison@gmail.com> - 2017-05-08 00:20 +0200
      [PATCH v6] staging: rtl8723bs: remove re-positioned call to kfree in  os_dep/ioctl_cfg80211.c Ian W MORRISON <ianwmorrison@gmail.com> - 2017-05-08 15:50 +0200
      Re: [PATCH v5] staging: rtl8723bs: remove re-positioned call to kfree  in os_dep/ioctl_cfg80211.c Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-08 16:50 +0200

csiph-web