Re: [PATCH] firmware: Google VPD: Fix memory allocation error handling

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] firmware: Google VPD: Fix memory allocation error handling
Date	2017-05-06 10:50 +0200
Message-ID	<tE3zB-5O0-27@gated-at.bofh.it> (permalink)
References	<tDQVH-5Uw-1@gated-at.bofh.it> <tDRyp-6eu-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 05, 2017 at 12:56:47PM -0700, Greg KH wrote:
> On Fri, May 05, 2017 at 09:08:44PM +0200, Christophe JAILLET wrote:
> > This patch fixes several issues:
> >    - if the 1st 'kzalloc' fails, we dereference a NULL pointer
> >    - if the 2nd 'kzalloc' fails, there is a memory leak
> >    - if 'sysfs_create_bin_file' fails there is also a memory leak
> 
> Then it should be multiple patches, not fixing 3 things in one patch,
> right?
> 

I agree with Christophe that this is basically one thing.  Otherwise you
end up breaking it up how Elfring does it into tiny tiny snippets that I
can't read.  Doing it this way is easier to review for me.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] firmware: Google VPD: Fix memory allocation error handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-05-05 21:20 +0200
  Re: [PATCH] firmware: Google VPD: Fix memory allocation error  handling Greg KH <gregkh@linuxfoundation.org> - 2017-05-05 22:00 +0200
    Re: [PATCH] firmware: Google VPD: Fix memory allocation error  handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-05-06 07:10 +0200
    Re: [PATCH] firmware: Google VPD: Fix memory allocation error  handling Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-06 10:50 +0200

csiph-web