Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1636694

Re: [PATCH] firmware: Google VPD: Fix memory allocation error handling

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] firmware: Google VPD: Fix memory allocation error handling
Date 2017-05-05 22:00 +0200
Message-ID <tDRyp-6eu-11@gated-at.bofh.it> (permalink)
References <tDQVH-5Uw-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, May 05, 2017 at 09:08:44PM +0200, Christophe JAILLET wrote:
> This patch fixes several issues:
>    - if the 1st 'kzalloc' fails, we dereference a NULL pointer
>    - if the 2nd 'kzalloc' fails, there is a memory leak
>    - if 'sysfs_create_bin_file' fails there is also a memory leak

Then it should be multiple patches, not fixing 3 things in one patch,
right?

thanks,

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] firmware: Google VPD: Fix memory allocation error handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-05-05 21:20 +0200
  Re: [PATCH] firmware: Google VPD: Fix memory allocation error  handling Greg KH <gregkh@linuxfoundation.org> - 2017-05-05 22:00 +0200
    Re: [PATCH] firmware: Google VPD: Fix memory allocation error  handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-05-06 07:10 +0200
    Re: [PATCH] firmware: Google VPD: Fix memory allocation error  handling Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-06 10:50 +0200

csiph-web