Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1636013

Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts()

From Chris Wilson <chris@chris-wilson.co.uk>
Newsgroups linux.kernel
Subject Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts()
Date 2017-05-04 22:20 +0200
Message-ID <tDvoe-8mr-1@gated-at.bofh.it> (permalink)
References <tDsgF-6aT-3@gated-at.bofh.it> <tDsgG-6aT-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, May 04, 2017 at 06:54:16PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 4 May 2017 13:20:47 +0200
> 
> Some strings which did not contain data format specifications should be put
> into a sequence. Thus use the corresponding function "seq_puts".

debugfs / seq_file is not performance critical. Familiar idiomatic code is
much preferred over continually switching between seq_printf and seq_puts.

And don't even start on converting seq_printf / seq_puts to seq_putc...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 19:00 +0200
  Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts() Chris Wilson <chris@chris-wilson.co.uk> - 2017-05-04 22:20 +0200
    Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts() Jani Nikula <jani.nikula@linux.intel.com> - 2017-05-05 08:00 +0200

csiph-web