Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts()

From	Jani Nikula <jani.nikula@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts()
Date	2017-05-05 08:00 +0200
Message-ID	<tDErv-5VP-3@gated-at.bofh.it> (permalink)
References	<tDsgF-6aT-3@gated-at.bofh.it> <tDsgG-6aT-29@gated-at.bofh.it> <tDvoe-8mr-1@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Thu, 04 May 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, May 04, 2017 at 06:54:16PM +0200, SF Markus Elfring wrote:
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Thu, 4 May 2017 13:20:47 +0200
>> 
>> Some strings which did not contain data format specifications should be put
>> into a sequence. Thus use the corresponding function "seq_puts".
>
> debugfs / seq_file is not performance critical. Familiar idiomatic code is
> much preferred over continually switching between seq_printf and seq_puts.
>
> And don't even start on converting seq_printf / seq_puts to seq_putc...

Agreed. I don't want any of the seq_* changes in this series.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 19:00 +0200
  Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts() Chris Wilson <chris@chris-wilson.co.uk> - 2017-05-04 22:20 +0200
    Re: [PATCH 3/9] drm/i915: Replace 14 seq_printf() calls by seq_puts() Jani Nikula <jani.nikula@linux.intel.com> - 2017-05-05 08:00 +0200

csiph-web