Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1636039

[PATCH 6/6] cxgb4: Combine substrings for two messages

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 6/6] cxgb4: Combine substrings for two messages
Date 2017-05-04 22:40 +0200
Message-ID <tDvHA-8tt-37@gated-at.bofh.it> (permalink)
References <tDvHz-8tt-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 4 May 2017 22:16:57 +0200

The script "checkpatch.pl" pointed information out like the following.

WARNING: quoted string split across lines

Thus fix two source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
index 32add8dfc253..f9384d8b680d 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
@@ -1353,8 +1353,9 @@ static int mps_trc_show(struct seq_file *seq, void *v)
 	if (tp.port < 8) {
 		i = adap->chan_map[tp.port & 3];
 		if (i >= MAX_NPORTS) {
-			dev_err(adap->pdev_dev, "tracer %u is assigned "
-				"to non-existing port\n", trcidx);
+			dev_err(adap->pdev_dev,
+				"tracer %u is assigned to non-existing port\n",
+				trcidx);
 			return -EINVAL;
 		}
 		seq_printf(seq, "tracer is capturing %s %s, ",
@@ -1798,11 +1799,11 @@ static int mps_tcam_show(struct seq_file *seq, void *v)
 				      FW_LDST_CMD_IDX_V(idx));
 			ret = t4_wr_mbox(adap, adap->mbox, &ldst_cmd,
 					 sizeof(ldst_cmd), &ldst_cmd);
-			if (ret)
-				dev_warn(adap->pdev_dev, "Can't read MPS "
-					 "replication map for idx %d: %d\n",
+			if (ret) {
+				dev_warn(adap->pdev_dev,
+					 "Can't read MPS replication map for idx %d: %d\n",
 					 idx, -ret);
-			else {
+			} else {
 				mps_rplc = ldst_cmd.u.mps.rplc;
 				rplc[0] = ntohl(mps_rplc.rplc31_0);
 				rplc[1] = ntohl(mps_rplc.rplc63_32);
-- 
2.12.2

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/6] cxgb4: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:40 +0200
  [PATCH 1/6] cxgb4vf: Use seq_putc() in mboxlog_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:40 +0200
  [PATCH 5/6] cxgb4: Use seq_puts() in cim_qcfg_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:40 +0200
  [PATCH 4/6] cxgb4: Replace seven seq_puts() calls by seq_putc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:40 +0200
  [PATCH 2/6] cxgb4vf: Combine substrings for 24 messages SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:40 +0200
  [PATCH 6/6] cxgb4: Combine substrings for two messages SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:40 +0200
  [PATCH 3/6] cxgb4vf: Adjust five checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:40 +0200
  Re: [PATCH 0/6] cxgb4: Fine-tuning for some function implementations Ganesh GR <ganeshgr@chelsio.com> - 2017-05-09 11:50 +0200

csiph-web