Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1636026

[PATCH 5/6] cxgb4: Use seq_puts() in cim_qcfg_show()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 5/6] cxgb4: Use seq_puts() in cim_qcfg_show()
Date 2017-05-04 22:40 +0200
Message-ID <tDvHA-8tt-25@gated-at.bofh.it> (permalink)
References <tDvHz-8tt-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 4 May 2017 21:52:32 +0200

A string which did not contain a data format specification should be put
into a sequence. Thus use the corresponding function "seq_puts".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
index 2bc40d89f874..32add8dfc253 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
@@ -357,9 +357,8 @@ static int cim_qcfg_show(struct seq_file *seq, void *v)
 		return i;
 
 	t4_read_cimq_cfg(adap, base, size, thres);
-
-	seq_printf(seq,
-		   "  Queue  Base  Size Thres  RdPtr WrPtr  SOP  EOP Avail\n");
+	seq_puts(seq,
+		 "  Queue  Base  Size Thres  RdPtr WrPtr  SOP  EOP Avail\n");
 	for (i = 0; i < CIM_NUM_IBQ; i++, p += 4)
 		seq_printf(seq, "%7s %5x %5u %5u %6x  %4x %4u %4u %5u\n",
 			   qname[i], base[i], size[i], thres[i],
-- 
2.12.2

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/6] cxgb4: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:40 +0200
  [PATCH 1/6] cxgb4vf: Use seq_putc() in mboxlog_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:40 +0200
  [PATCH 5/6] cxgb4: Use seq_puts() in cim_qcfg_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:40 +0200
  [PATCH 4/6] cxgb4: Replace seven seq_puts() calls by seq_putc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:40 +0200
  [PATCH 2/6] cxgb4vf: Combine substrings for 24 messages SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:40 +0200
  [PATCH 6/6] cxgb4: Combine substrings for two messages SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:40 +0200
  [PATCH 3/6] cxgb4vf: Adjust five checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:40 +0200
  Re: [PATCH 0/6] cxgb4: Fine-tuning for some function implementations Ganesh GR <ganeshgr@chelsio.com> - 2017-05-09 11:50 +0200

csiph-web