Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1635737

[PATCH] use get_random_long for the per-task stack canary

Show all headers | View raw

The stack canary is an unsigned long and should be fully initialized to
random data rather than only 32 bits of random data.

Cc: stable@vger.kernel.org
Signed-off-by: Daniel Micay <danielmicay@gmail.com>
---
 kernel/fork.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index 56d85fd81411..ff84ff82f56a 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -537,7 +537,7 @@ static struct task_struct *dup_task_struct(struct task_struct *orig, int node)
 	set_task_stack_end_magic(tsk);
 
 #ifdef CONFIG_CC_STACKPROTECTOR
-	tsk->stack_canary = get_random_int();
+	tsk->stack_canary = get_random_long();
 #endif
 
 	/*
-- 
2.12.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] use get_random_long for the per-task stack canary Daniel Micay <danielmicay@gmail.com> - 2017-05-04 15:40 +0200
  Re: [kernel-hardening] [PATCH] use get_random_long for the per-task  stack canary Rik van Riel <riel@redhat.com> - 2017-05-04 16:10 +0200
    Re: [kernel-hardening] [PATCH] use get_random_long for the per-task  stack canary Kees Cook <keescook@chromium.org> - 2017-05-04 16:40 +0200
  [tip:core/urgent] stackprotector: Increase the per-task stack  canary's random range from 32 bits to 64 bits on 64-bit platforms tip-bot for Daniel Micay <tipbot@zytor.com> - 2017-05-05 10:20 +0200

csiph-web