Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1635727
| From | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible |
| Date | 2017-05-04 15:20 +0200 |
| Message-ID | <tDoPM-3W2-13@gated-at.bofh.it> (permalink) |
| References | <ty4oF-7U8-17@gated-at.bofh.it> <tCYiB-2Mi-7@gated-at.bofh.it> <tDaMO-2Zz-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, May 04, 2017 at 12:16:20AM +0200, Alexandre Belloni wrote:
> On 03/05/2017 at 16:50:12 +0800, Shawn Guo wrote:
> > On Wed, Apr 19, 2017 at 10:22:02PM +0200, Alexandre Belloni wrote:
> > > The rv4162 vendor is microcrystal, not ST.
> > >
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > > ---
> > > arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > > index bad3c9f9eeac..b63134e3b51a 100644
> > > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > > @@ -408,7 +408,7 @@
> > > };
> > >
> > > rtc: rtc@68 {
> > > - compatible = "st,rv4162";
> > > + compatible = "microcrystal,rv4162";
> >
> > The compatible is not documented?
> >
>
> No, it wasn't. Like for many i2c devices, the driver predates DT and
> didn't need any specific code to be used from DT. Basically, the i2c
> core was using the i2c_device_ids to match the DT compatible string.
> This is changing since cabcf4f6be658b2d4bea26dee89d08fdf67d6811.
>
> I'm planning to document all the undocumented ones soon.
I applied all 3 patches. Please remember to document the compatible.
Shawn
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible Shawn Guo <shawnguo@kernel.org> - 2017-05-03 11:00 +0200
Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-04 00:20 +0200
Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible Shawn Guo <shawnguo@kernel.org> - 2017-05-04 15:20 +0200
Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible Fabio Estevam <festevam@gmail.com> - 2017-05-04 00:20 +0200
Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-04 00:30 +0200
csiph-web