Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1635507
| Path | csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Milian Wolff <milian.wolff@kdab.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v1 2/2] perf report: Display titles in left frame of annotate browser |
| Date | Thu, 04 May 2017 11:10:03 +0200 |
| Message-ID | <tDkVR-1oS-33@gated-at.bofh.it> (permalink) |
| References | <tDj3H-bE-5@gated-at.bofh.it> <tDj3H-bE-19@gated-at.bofh.it> |
| X-Original-To | Jin Yao <yao.jin@linux.intel.com> |
| Organization | KDAB |
| MIME-Version | 1.0 |
| Content-Transfer-Encoding | 8BIT |
| Content-Type | text/plain; charset="UTF-8" |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 47 |
| X-Original-Cc | acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com |
| X-Original-Date | Thu, 04 May 2017 11:01:48 +0200 |
| X-Original-Message-ID | <8076707.4PSiRuChLW@milian-kdab2> |
| X-Original-References | <1493909895-9668-1-git-send-email-yao.jin@linux.intel.com> <1493909895-9668-3-git-send-email-yao.jin@linux.intel.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1635507 |
Show key headers only | View raw
On Thursday, May 4, 2017 4:58:15 PM CEST Jin Yao wrote:
> The annotate browser is divided into 2 frames. Left frame
> contains 3 columns (some platforms only have one column).
>
> For example:
>
> │26 int compute_flag()
> │27 {
> 22.80 1.20 │ sub $0x8,%rsp
> │25 int i;
> │
> │27 i = rand() % 2;
> 22.78 1.20 1 │ → callq rand@plt
>
> While it's hard for user to understand what the data is.
>
> This patch adds the titles "Percent", "IPC" and "Cycle"
> on columns.
>
> Percnt IPC Cycle │
> │25 __attribute__((noinline))
> │26 int compute_flag()
> │27 {
> 22.80 1.20 │ sub $0x8,%rsp
> │25 int i;
> │
> │27 i = rand() % 2;
> 22.78 1.20 1 │ → callq rand@plt
>
> The titles are displayed at row 0 of annotate browser if row 0
> doesn't have values of percent, ipc and cycle.
Functionality wise a really good improvement - thanks! But personally I find
the abbreviation of one character (i.e. "Percnt" instead of "Percent") not so
nice. If space really is an issue here, use "%"?
Also note though that it's unclear what this percentage actually is. I guess
it's a sample percentage? Maybe a header should be added that explains these
values to newbies. I bet many people won't even know what IPC is either.
Cheers
--
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v1 2/2] perf report: Display titles in left frame of annotate browser Jin Yao <yao.jin@linux.intel.com> - 2017-05-04 09:10 +0200
Re: [PATCH v1 2/2] perf report: Display titles in left frame of annotate browser Milian Wolff <milian.wolff@kdab.com> - 2017-05-04 11:10 +0200
Re: [PATCH v1 2/2] perf report: Display titles in left frame of annotate browser Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-05-04 15:20 +0200
Re: [PATCH v1 2/2] perf report: Display titles in left frame of annotate browser Milian Wolff <milian.wolff@kdab.com> - 2017-05-04 16:10 +0200
Re: [PATCH v1 2/2] perf report: Display titles in left frame of annotate browser Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-05-04 17:00 +0200
csiph-web