Re: [PATCH v1 2/2] perf report: Display titles in left frame of annotate browser

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 2/2] perf report: Display titles in left frame of annotate browser
Date	2017-05-04 17:00 +0200
Message-ID	<tDqoy-4PF-11@gated-at.bofh.it> (permalink)
References	<tDj3H-bE-5@gated-at.bofh.it> <tDkVR-1oS-33@gated-at.bofh.it> <tDoPL-3W2-3@gated-at.bofh.it> <tDpC9-4uB-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Thu, May 04, 2017 at 04:04:42PM +0200, Milian Wolff escreveu:
> On Thursday, May 4, 2017 3:12:50 PM CEST Arnaldo Carvalho de Melo wrote:
> > Em Thu, May 04, 2017 at 11:01:48AM +0200, Milian Wolff escreveu:
> > > On Thursday, May 4, 2017 4:58:15 PM CEST Jin Yao wrote:
> > > > This patch adds the titles "Percent", "IPC" and "Cycle"
> > > > on columns.
> > > > 
> > > > Percnt   IPC Cycle │
> > > > 
> > > >                    │25  __attribute__((noinline))
> > > >                    │26  int compute_flag()
> > > >                    │27  {
> > > >  
> > > >  22.80  1.20       │      sub    $0x8,%rsp
> > > >  
> > > >                    │25          int i;
> > > >                    │
> > > >                    │27          i = rand() % 2;
> > > >  
> > > >  22.78  1.20     1 │    → callq  rand@plt
> > > > 
> > > > The titles are displayed at row 0 of annotate browser if row 0
> > > > doesn't have values of percent, ipc and cycle.
> > > 
> > > Functionality wise a really good improvement - thanks! But personally I
> > > find the abbreviation of one character (i.e. "Percnt" instead of
> > > "Percent") not so nice. If space really is an issue here, use "%"?
> > 
> > Ok, will make it 'Percent' as we have space for that, and will add
> > Acked-by: Millian, ok?
> 
> Just one L, but otherwise yes :)

Sure, sorry about that, c'n'pasted from a message from you, so should be
all well. 
 
> > > Also note though that it's unclear what this percentage actually is. I
> > > guess it's a sample percentage? Maybe a header should be added that
> > > explains these values to newbies. I bet many people won't even know what
> > > IPC is either.
> > Perhaps we could have some help files, then when the user presses 'h'
> > one of the lines would be:
> > 
> >   h   Report explanation (columns, etc)
> 
> Yeah I think that would be a good addition for the future.

:-)

- Arnaldo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 2/2] perf report: Display titles in left frame of annotate browser Jin Yao <yao.jin@linux.intel.com> - 2017-05-04 09:10 +0200
  Re: [PATCH v1 2/2] perf report: Display titles in left frame of annotate browser Milian Wolff <milian.wolff@kdab.com> - 2017-05-04 11:10 +0200
    Re: [PATCH v1 2/2] perf report: Display titles in left frame of  annotate browser Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-05-04 15:20 +0200
      Re: [PATCH v1 2/2] perf report: Display titles in left frame of annotate browser Milian Wolff <milian.wolff@kdab.com> - 2017-05-04 16:10 +0200
        Re: [PATCH v1 2/2] perf report: Display titles in left frame of  annotate browser Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-05-04 17:00 +0200

csiph-web