Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1635433

Re: [PATCH] xen/x86: Do not call xen_init_time_ops() until shared_info is initialized

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Juergen Gross <jgross@suse.com>
Newsgroups linux.kernel
Subject Re: [PATCH] xen/x86: Do not call xen_init_time_ops() until shared_info is initialized
Date Thu, 04 May 2017 08:40:01 +0200
Message-ID <tDiAF-8dQ-3@gated-at.bofh.it> (permalink)
References <tD94l-1P1-5@gated-at.bofh.it>
X-Original-To Boris Ostrovsky <boris.ostrovsky@oracle.com>
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version 1.0
Content-Type text/plain; charset=windows-1252
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 18
Organization linux.* mail to news gateway
X-Original-Cc xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
X-Original-Date Thu, 4 May 2017 08:37:30 +0200
X-Original-Message-ID <c354354a-37e2-f657-bfd1-87be59e569d9@suse.com>
X-Original-References <1493842851-10859-1-git-send-email-boris.ostrovsky@oracle.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1635433

Show key headers only | View raw


On 03/05/17 22:20, Boris Ostrovsky wrote:
> Routines that are set by xen_init_time_ops() use shared_info's
> pvclock_vcpu_time_info area. This area is not properly available until
> shared_info is mapped in xen_setup_shared_info().
> 
> This became especially problematic due to commit dd759d93f4dd ("x86/timers:
> Add simple udelay calibration") where we end up reading tsc_to_system_mul
> from xen_dummy_shared_info (i.e. getting zero value) and then trying
> to divide by it in pvclock_tsc_khz().
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Thanks,

Juergen

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] xen/x86: Do not call xen_init_time_ops() until shared_info is initialized Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-05-03 22:30 +0200
  Re: [PATCH] xen/x86: Do not call xen_init_time_ops() until  shared_info is initialized Juergen Gross <jgross@suse.com> - 2017-05-04 08:40 +0200
  Re: [PATCH] xen/x86: Do not call xen_init_time_ops() until  shared_info is initialized Juergen Gross <jgross@suse.com> - 2017-05-05 11:00 +0200

csiph-web