Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1635433

Re: [PATCH] xen/x86: Do not call xen_init_time_ops() until shared_info is initialized

Show all headers | View raw

On 03/05/17 22:20, Boris Ostrovsky wrote:
> Routines that are set by xen_init_time_ops() use shared_info's
> pvclock_vcpu_time_info area. This area is not properly available until
> shared_info is mapped in xen_setup_shared_info().
> 
> This became especially problematic due to commit dd759d93f4dd ("x86/timers:
> Add simple udelay calibration") where we end up reading tsc_to_system_mul
> from xen_dummy_shared_info (i.e. getting zero value) and then trying
> to divide by it in pvclock_tsc_khz().
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Thanks,

Juergen

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] xen/x86: Do not call xen_init_time_ops() until shared_info is initialized Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-05-03 22:30 +0200
  Re: [PATCH] xen/x86: Do not call xen_init_time_ops() until  shared_info is initialized Juergen Gross <jgross@suse.com> - 2017-05-04 08:40 +0200
  Re: [PATCH] xen/x86: Do not call xen_init_time_ops() until  shared_info is initialized Juergen Gross <jgross@suse.com> - 2017-05-05 11:00 +0200

csiph-web