Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1636686

Re: [PATCH v2 03/10] pinctrl: sunxi: add A20 support to A10 driver

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, May 04, 2017 at 10:45:11PM +0800, Icenowy Zheng wrote:
> 
> 
> 于 2017年5月4日 GMT+08:00 下午10:41:52, Maxime Ripard <maxime.ripard@free-electrons.com> 写到:
> >On Thu, May 04, 2017 at 10:03:26PM +0800, Icenowy Zheng wrote:
> >> 
> >> 
> >> 于 2017年5月4日 GMT+08:00 下午10:02:20, Maxime Ripard
> ><maxime.ripard@free-electrons.com> 写到:
> >> >On Thu, May 04, 2017 at 09:49:59PM +0800, Icenowy Zheng wrote:
> >> >>  static const struct of_device_id sun4i_a10_pinctrl_match[] = {
> >> >> -	{ .compatible = "allwinner,sun4i-a10-pinctrl", },
> >> >> +	{
> >> >> +		.compatible = "allwinner,sun4i-a10-pinctrl",
> >> >> +		.data = (void *)PINCTRL_SUN4I_A10
> >> >> +	},
> >> >> +	{
> >> >> +		.compatible = "allwinner,sun7i-a20-pinctrl",
> >> >> +		.data = (void *)PINCTRL_SUN7I_A20
> >> >> +	},
> >> >>  	{}
> >> >>  };
> >> >
> >> >This means you're going to have two drivers probing for the same
> >> >device: this driver, and the old one. This is not ok, and probably
> >> >introduces some corner cases.
> >> 
> >> The A20 driver is dropped in the next commit.
> >
> >Yes, and that is an issue for bisectability. Anyone that will checkout
> >between those two commits will have a broken kernel, and that is not
> >ok. Any commit should be in a working state.
> 
> Squash them together?

I would simply remove the A20's def_bool in that patch.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/10] Initial Allwinner R40 support Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:00 +0200
  Re: [PATCH v2 03/10] pinctrl: sunxi: add A20 support to A10 driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 16:10 +0200
    Re: [PATCH v2 03/10] pinctrl: sunxi: add A20 support to A10 driver Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:10 +0200
      Re: [PATCH v2 03/10] pinctrl: sunxi: add A20 support to A10 driver Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:50 +0200
        Re: [PATCH v2 03/10] pinctrl: sunxi: add A20 support to A10 driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-05 21:50 +0200
      Re: [PATCH v2 03/10] pinctrl: sunxi: add A20 support to A10 driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 16:50 +0200
  [PATCH v2 07/10] dt-bindings: add compatible string for Allwinner R40 CCU Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:20 +0200
    Re: [PATCH v2 07/10] dt-bindings: add compatible string for  Allwinner R40 CCU Rob Herring <robh@kernel.org> - 2017-05-08 18:50 +0200
  [PATCH v2 06/10] pinctrl: sunxi: add support of R40 to A10 pinctrl driver Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:20 +0200
  [PATCH v2 03/10] pinctrl: sunxi: add A20 support to A10 driver Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:20 +0200
  [PATCH v2 05/10] dt-bindings: add compatible string for Allwinner R40 pinctrl Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:20 +0200
    Re: [PATCH v2 05/10] dt-bindings: add compatible string for  Allwinner R40 pinctrl Rob Herring <robh@kernel.org> - 2017-05-08 18:50 +0200
  Re: [PATCH v2 08/10] clk: sunxi-ng: support R40 SoC Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 16:30 +0200
  Re: [PATCH v2 09/10] ARM: dts: sun8i: Add basic dtsi file for  Allwinner R40 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 16:40 +0200
  [PATCH v2 09/10] ARM: dts: sun8i: Add basic dtsi file for Allwinner R40 Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 17:30 +0200
  Re: [PATCH v2 04/10] pinctrl: sunxi: switch A20's pinctrl driver to  use the A10 version Linus Walleij <linus.walleij@linaro.org> - 2017-05-11 16:50 +0200

csiph-web