[PATCH] ceph: Check that the new inode size is within limits in ceph_fallocate()

From	Luis Henriques <lhenriques@suse.com>
Newsgroups	linux.kernel
Subject	[PATCH] ceph: Check that the new inode size is within limits in ceph_fallocate()
Date	2017-05-05 19:40 +0200
Message-ID	<tDPmV-4Oe-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Currently the ceph client doesn't respect the rlimit in fallocate.  This
means that a user can allocate a file with size > RLIMIT_FSIZE.  This
patch adds the call to inode_newsize_ok() to verify filesystem limits and
ulimits.  This should make ceph successfully run xfstest generic/228.

Signed-off-by: Luis Henriques <lhenriques@suse.com>
---
 fs/ceph/file.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/fs/ceph/file.c b/fs/ceph/file.c
index 26cc95421cca..bc5809d4d2d4 100644
--- a/fs/ceph/file.c
+++ b/fs/ceph/file.c
@@ -1636,8 +1636,12 @@ static long ceph_fallocate(struct file *file, int mode,
 	}
 
 	size = i_size_read(inode);
-	if (!(mode & FALLOC_FL_KEEP_SIZE))
+	if (!(mode & FALLOC_FL_KEEP_SIZE)) {
 		endoff = offset + length;
+		ret = inode_newsize_ok(inode, endoff);
+		if (ret)
+			goto unlock;
+	}
 
 	if (fi->fmode & CEPH_FILE_MODE_LAZY)
 		want = CEPH_CAP_FILE_BUFFER | CEPH_CAP_FILE_LAZYIO;

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ceph: Check that the new inode size is within limits in ceph_fallocate() Luis Henriques <lhenriques@suse.com> - 2017-05-05 19:40 +0200
  Re: [PATCH] ceph: Check that the new inode size is within limits in ceph_fallocate() "Yan, Zheng" <ukernel@gmail.com> - 2017-05-08 04:20 +0200

csiph-web