Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1636510
| From | Borislav Petkov <bp@suse.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [v6 PATCH 08/21] x86/insn-eval: Add utility function to get segment descriptor base address |
| Date | 2017-05-05 19:30 +0200 |
| Message-ID | <tDPdf-4Km-5@gated-at.bofh.it> (permalink) |
| References | <tixO1-76a-3@gated-at.bofh.it> <tixO1-76a-9@gated-at.bofh.it> <tyfN9-6Do-23@gated-at.bofh.it> <tADLj-eg-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Apr 26, 2017 at 03:37:44PM -0700, Ricardo Neri wrote:
> I need a human-readable way of identifying what segment selector (in
> pt_regs, vm86regs or directly reading the segment registers) to use.
> Since there is a segment override prefix for all of them, I thought I
> could use them.
Yes, you should...
> Perhaps I can rename enum segment to enum segment_selector and comment
> that the values in the enum are those of the override prefixes. Would
> that be reasonable?
... but you should call them what they are: "enum seg_override_pfxs" or
"enum seg_ovr_pfx" or...
Or somesuch. I suck at naming stuff.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [v6 PATCH 08/21] x86/insn-eval: Add utility function to get segment descriptor base address Ricardo Neri <ricardo.neri-calderon@linux.intel.com> - 2017-04-27 00:40 +0200 Re: [v6 PATCH 08/21] x86/insn-eval: Add utility function to get segment descriptor base address Borislav Petkov <bp@suse.de> - 2017-05-05 19:30 +0200
csiph-web