Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1636383

Re: [PATCH] HID: magicmouse: Set multi-touch keybits for Magic Mouse

From Jiri Kosina <jikos@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] HID: magicmouse: Set multi-touch keybits for Magic Mouse
Date 2017-05-05 15:40 +0200
Message-ID <tDLCF-2l3-3@gated-at.bofh.it> (permalink)
References <ttxhE-4AV-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 7 Apr 2017, Thierry Escande wrote:

> From: Che-Liang Chiou <clchiou@chromium.org>
> 
> The driver emits multi-touch events for Magic Trackpad as well as Magic
> Mouse, but it does not set keybits that are related to multi-touch event
> for Magic Mouse; so set these keybits.
> 
> The keybits that are not set cause trouble because user programs often
> probe these keybits for self-configuration and thus they cannot operate
> properly if the keybits are not set.
> 
> One of such troubles is that libevdev will not be able to emit correct
> touch count, causing gestures library failed to do fling stop.
> 
> Signed-off-by: Che-Liang Chiou <clchiou@chromium.org>
> Signed-off-by: Thierry Escande <thierry.escande@collabora.com>

Applied to for-4.12/upstream-fixes. Thanks,

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] HID: magicmouse: Set multi-touch keybits for Magic  Mouse Jiri Kosina <jikos@kernel.org> - 2017-05-05 15:40 +0200

csiph-web