Re: [PATCH] Fixed a pathing issue with objdump and grep

From	Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Fixed a pathing issue with objdump and grep
Date	2017-05-05 15:40 +0200
Message-ID	<tDLCF-2l3-1@gated-at.bofh.it> (permalink)
References	<tD1qa-5fK-17@gated-at.bofh.it> <tDKZX-1Q5-1@gated-at.bofh.it> <tDLt0-2gd-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Friday 05 May 2017 06:52 PM, Ravi Bangoria wrote:
>
> On Friday 05 May 2017 06:27 PM, Arnaldo Carvalho de Melo wrote:
>> Em Wed, May 03, 2017 at 12:12:23PM +0000, Adam Stylinski escreveu:
>>> The path fed to the argument for objdump used in the perf-annotate
>>> feature didn't escape spaces. The subsequent argument to grep for
>>> the name of the DSO containing symbols also assumed no spaces existed
>>> in the pathname, so grep also parsed these as extra positional
>>> arguments.
>> This one didn't apply to tip/perf/urgent, so I tried another patch
>> addressing the same issue, from Ravi Bangoria, and it applied, ok?
> Oh, I was not aware about this patch. Coincidently, I sent the same fix. :)

BTW, Adam, Looks like you have older code. The same line was recently
changed by Taeung Song in commit e7cb9de211ebb29. I don't see that
change in your code.

Ravi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Fixed a pathing issue with objdump and grep Adam Stylinski <adam.stylinski@etegent.com> - 2017-05-03 14:20 +0200
  Re: [PATCH] Fixed a pathing issue with objdump and grep Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-05-05 15:00 +0200
    Re: [PATCH] Fixed a pathing issue with objdump and grep Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-05-05 15:30 +0200
      Re: [PATCH] Fixed a pathing issue with objdump and grep Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-05-05 15:40 +0200

csiph-web