Re: [PATCH v1] ACPI: Switch to use generic UUID API

From	Amir Goldstein <amir73il@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1] ACPI: Switch to use generic UUID API
Date	2017-05-05 12:10 +0200
Message-ID	<tDIls-h7-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <tDEUy-6lR-11@gated-at.bofh.it> <tDFxf-6U1-1@gated-at.bofh.it> <tDHIJ-8ec-9@gated-at.bofh.it> <tDIbM-8pT-7@gated-at.bofh.it> <tDIbM-8pT-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 5, 2017 at 12:57 PM, Christoph Hellwig <hch@lst.de> wrote:
> On Fri, May 05, 2017 at 12:50:31PM +0300, Amir Goldstein wrote:
>> To complete the picture for folks not cc'ed on my patches,
>> xfs use case suggests there is also justification for the additional helpers:
>>
>> uuid_is_null() / uuid_equal()
>> guid_is_null() / guid_equal()
>
> The is_null is useful and I bet we'll find other instances. I'm
> not sure _equals really adds much value over the existing _cmp
> helpers, but on the other hand they are so trivial that we might as
> well add them.

Exactly. The fact that not only xfs used the same helper name
(drivers/md/md.c) suggests that it useful.

>
> The other thing XFS has is uuid_copy.

Andy already listed uuid_copy.

Thread

[PATCH v1] ACPI: Switch to use generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-04 11:30 +0200
  Re: [PATCH v1] ACPI: Switch to use generic UUID API Jani Nikula <jani.nikula@linux.intel.com> - 2017-05-04 11:40 +0200
  Re: [PATCH v1] ACPI: Switch to use generic UUID API Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2017-05-04 14:20 +0200
  Re: [PATCH v1] ACPI: Switch to use generic UUID API Joerg Roedel <joro@8bytes.org> - 2017-05-04 14:50 +0200
  Re: [PATCH v1] ACPI: Switch to use generic UUID API Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-05-04 17:30 +0200
  Re: [Intel-gfx] [PATCH v1] ACPI: Switch to use generic UUID API kbuild test robot <lkp@intel.com> - 2017-05-05 08:10 +0200
  Re: [PATCH v1] ACPI: Switch to use generic UUID API Dan Williams <dan.j.williams@intel.com> - 2017-05-05 08:30 +0200
    Re: [PATCH v1] ACPI: Switch to use generic UUID API Amir Goldstein <amir73il@gmail.com> - 2017-05-05 09:10 +0200
      Re: [PATCH v1] ACPI: Switch to use generic UUID API Christoph Hellwig <hch@lst.de> - 2017-05-05 09:40 +0200
      Re: [PATCH v1] ACPI: Switch to use generic UUID API Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-05 11:30 +0200
        Re: [PATCH v1] ACPI: Switch to use generic UUID API Amir Goldstein <amir73il@gmail.com> - 2017-05-05 12:00 +0200
          Re: [PATCH v1] ACPI: Switch to use generic UUID API Christoph Hellwig <hch@lst.de> - 2017-05-05 12:00 +0200
            Re: [PATCH v1] ACPI: Switch to use generic UUID API Amir Goldstein <amir73il@gmail.com> - 2017-05-05 12:10 +0200
  Re: [PATCH v1] ACPI: Switch to use generic UUID API Felipe Balbi <balbi@kernel.org> - 2017-05-09 10:00 +0200
  Re: [PATCH v1] ACPI: Switch to use generic UUID API Mathias Nyman <mathias.nyman@linux.intel.com> - 2017-05-09 10:30 +0200
  Re: [PATCH v1] ACPI: Switch to use generic UUID API Zhang Rui <rui.zhang@intel.com> - 2017-05-10 03:30 +0200

csiph-web