Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1636304
| From | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 |
| Date | 2017-05-05 12:50 +0200 |
| Message-ID | <tDIY9-yX-5@gated-at.bofh.it> (permalink) |
| References | <tDF4d-6re-3@gated-at.bofh.it> <tDI26-8l5-3@gated-at.bofh.it> <tDIEN-s5-3@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Fri, May 05, 2017 at 12:23:26PM +0200, Jan Kiszka wrote:
> >> + } else {
> >> + st->reg = devm_regulator_get(&spi->dev, "vref");
> >> + if (IS_ERR(st->reg))
> >> + return PTR_ERR(st->reg);
> >
> > This should be an optional regulator and in case of ACPI you just don't
> > have it.
>
> It's mandatory for this DT case, so I will not change that.
Well, it would be better if you don't need to deviate in the driver like
this. And it clearly is optional because in case of ACPI you don't need
it.
Not my call, though.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-05 08:40 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-05 11:50 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-05 12:30 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-05 12:50 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-05 21:00 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-05 12:00 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-05 12:40 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-05 21:00 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-05 22:20 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-05 22:40 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-08 00:00 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-05 21:00 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-05 21:10 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-08 00:00 +0200
csiph-web