Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1636275
| From | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 |
| Date | 2017-05-05 11:50 +0200 |
| Message-ID | <tDI26-8l5-3@gated-at.bofh.it> (permalink) |
| References | <tDF4d-6re-3@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Fri, May 05, 2017 at 08:31:32AM +0200, Jan Kiszka wrote:
> +static int adc108s102_probe(struct spi_device *spi)
> +{
> + struct adc108s102_state *st;
> + struct iio_dev *indio_dev;
> + int ret;
> +
> + indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
> + if (!indio_dev)
> + return -ENOMEM;
> +
> + st = iio_priv(indio_dev);
> +
> + if (ACPI_COMPANION(&spi->dev)) {
> + st->reg = NULL;
> + ret = device_property_read_u32(&spi->dev, "va-millivolt",
> + &st->va_millivolt);
Please try to avoid things like this for now. You can just hard code the
voltage now and we can think how to solve this in ACPI if there will be
an actual user needing anything else than the voltage you are using on
your board.
> + if (ret < 0) {
> + dev_err(&spi->dev,
> + "Missing va-millivolt device property\n");
> + return -ENODEV;
> + }
> + } else {
> + st->reg = devm_regulator_get(&spi->dev, "vref");
> + if (IS_ERR(st->reg))
> + return PTR_ERR(st->reg);
This should be an optional regulator and in case of ACPI you just don't
have it.
> +
> + ret = regulator_enable(st->reg);
> + if (ret < 0) {
> + dev_err(&spi->dev, "Cannot enable vref regulator\n");
> + return ret;
> + }
> + }
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-05 08:40 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-05 11:50 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-05 12:30 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-05 12:50 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-05 21:00 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-05 12:00 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-05 12:40 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-05 21:00 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-05 22:20 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-05 22:40 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-08 00:00 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-05 21:00 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-05 21:10 +0200
Re: [PATCH v3] iio: adc: Add support for TI ADC108S102 and ADC128S102 Jonathan Cameron <jic23@kernel.org> - 2017-05-08 00:00 +0200
csiph-web