Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver

From	Andrew Lunn <andrew@lunn.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver
Date	2017-05-01 18:20 +0200
Message-ID	<tCmdk-2Ui-5@gated-at.bofh.it> (permalink)
References	<tCj5L-Qy-3@gated-at.bofh.it> <tCkbw-1IO-33@gated-at.bofh.it> <tCkEy-1S6-7@gated-at.bofh.it> <tCkOe-1Vi-17@gated-at.bofh.it> <tClTX-2yI-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> > > > Does the internal PHY have a phy driver? It seems like
> > > > tx-delay-ps/rx-delay-ps are properties of this internal PHY, and so
> > > > should be in the phy driver, if it has one.
> > > 
> > > Nope. These affect the delay lines for the external PHY interface.
> 
> I will add some sentences in the documentation to be more clear about that.

Thanks

> 
> > 
> > Oh, yes. I understood the patch wrong.
> > 
> > None of the patches actually use these properties. Are they actually
> > needed? We should avoid adding vendor specific properties, if they are
> > not used.
> > 
> 
> The board that use it is the BananaPi M3, but the SoC A83T still lack clocks support.
> So theses properties is already used out of tree, and will be used in tree soon.

Fair enough.

Thanks
	Andrew

Thread

[PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 17/20] arm64: allwinner: bananapi-m64: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 20/20] arm64: defconfig: Enable dwmac-sun8i driver on defconfig Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 09/20] arm: sun8i: orangepi-zero: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 18/20] arm: sunxi: Enable dwmac-sun8i driver on sunxi_defconfig Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 13/20] arm64: allwinner: sun50i-a64: Add dt node for the syscon control module Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 07/20] arm: sun8i: sunxi-h3-h5: add dwmac-sun8i ethernet driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 14/20] arm64: allwinner: sun50i-a64: add dwmac-sun8i Ethernet driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 16/20] arm64: allwinner: pine64-plus: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 15/20] arm64: allwinner: pine64: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 06/20] arm: sun8i: sunxi-h3-h5: Add dt node for the syscon control module Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 05/20] net: stmmac: Add dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 19/20] arm: multi_v7: Enable dwmac-sun8i driver on multi_v7_defconfig Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 08/20] arm: sun8i: orangepi-pc: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 12/20] arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 10/20] arm: sun8i: orangepi-one: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 01/20] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 04/20] dt-bindings: syscon: Add DT bindings documentation for Allwinner syscon Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
    Re: [PATCH v5 04/20] dt-bindings: syscon: Add DT bindings  documentation for Allwinner syscon Rob Herring <robh@kernel.org> - 2017-05-05 22:30 +0200
  [PATCH v5 11/20] arm: sun8i: orangepi-2: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet  driver Andrew Lunn <andrew@lunn.ch> - 2017-05-01 16:10 +0200
    Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver Chen-Yu Tsai <wens@csie.org> - 2017-05-01 16:40 +0200
      Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet  driver Andrew Lunn <andrew@lunn.ch> - 2017-05-01 16:50 +0200
        Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet  driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 18:00 +0200
          Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet  driver Andrew Lunn <andrew@lunn.ch> - 2017-05-01 18:20 +0200
  Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet  driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-05 14:20 +0200

csiph-web