Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1633713

Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver

Show all headers | View raw

On Mon, May 01, 2017 at 04:45:41PM +0200, Andrew Lunn wrote:
> On Mon, May 01, 2017 at 10:28:46PM +0800, Chen-Yu Tsai wrote:
> > On Mon, May 1, 2017 at 10:01 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> > > On Mon, May 01, 2017 at 02:45:00PM +0200, Corentin Labbe wrote:
> > >> Hello
> > >>
> > >> This patch series add the driver for dwmac-sun8i which handle the Ethernet MAC
> > >> present on Allwinner H3/H5/A83T/A64 SoCs.
> > >>
> > >> This driver is the continuation of the sun8i-emac driver.
> > >> During the development, it appeared that in fact the hardware was a modified
> > >> version of some dwmac.
> > >> So the driver is now written as a glue driver for stmmac.
> > >>
> > >> It supports 10/100/1000 Mbit/s speed with half/full duplex.
> > >> It can use an internal PHY (MII 10/100) or an external PHY
> > >> via RGMII/RMII.
> > >
> > > Hi Corentin
> > >
> > > Sorry if this has been asked before....
> > >
> > > Does the internal PHY have a phy driver? It seems like
> > > tx-delay-ps/rx-delay-ps are properties of this internal PHY, and so
> > > should be in the phy driver, if it has one.
> > 
> > Nope. These affect the delay lines for the external PHY interface.

I will add some sentences in the documentation to be more clear about that.

> 
> Oh, yes. I understood the patch wrong.
> 
> None of the patches actually use these properties. Are they actually
> needed? We should avoid adding vendor specific properties, if they are
> not used.
> 

The board that use it is the BananaPi M3, but the SoC A83T still lack clocks support.
So theses properties is already used out of tree, and will be used in tree soon.

Regards

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 17/20] arm64: allwinner: bananapi-m64: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 20/20] arm64: defconfig: Enable dwmac-sun8i driver on defconfig Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 09/20] arm: sun8i: orangepi-zero: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 18/20] arm: sunxi: Enable dwmac-sun8i driver on sunxi_defconfig Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 13/20] arm64: allwinner: sun50i-a64: Add dt node for the syscon control module Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 07/20] arm: sun8i: sunxi-h3-h5: add dwmac-sun8i ethernet driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 14/20] arm64: allwinner: sun50i-a64: add dwmac-sun8i Ethernet driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 16/20] arm64: allwinner: pine64-plus: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 15/20] arm64: allwinner: pine64: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 06/20] arm: sun8i: sunxi-h3-h5: Add dt node for the syscon control module Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 05/20] net: stmmac: Add dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 19/20] arm: multi_v7: Enable dwmac-sun8i driver on multi_v7_defconfig Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 08/20] arm: sun8i: orangepi-pc: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 12/20] arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 10/20] arm: sun8i: orangepi-one: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 01/20] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  [PATCH v5 04/20] dt-bindings: syscon: Add DT bindings documentation for Allwinner syscon Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
    Re: [PATCH v5 04/20] dt-bindings: syscon: Add DT bindings  documentation for Allwinner syscon Rob Herring <robh@kernel.org> - 2017-05-05 22:30 +0200
  [PATCH v5 11/20] arm: sun8i: orangepi-2: Enable dwmac-sun8i Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 15:00 +0200
  Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet  driver Andrew Lunn <andrew@lunn.ch> - 2017-05-01 16:10 +0200
    Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver Chen-Yu Tsai <wens@csie.org> - 2017-05-01 16:40 +0200
      Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet  driver Andrew Lunn <andrew@lunn.ch> - 2017-05-01 16:50 +0200
        Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet  driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-01 18:00 +0200
          Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet  driver Andrew Lunn <andrew@lunn.ch> - 2017-05-01 18:20 +0200
  Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet  driver Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-05 14:20 +0200

csiph-web