Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1633600

Re: [PATCH 2/5] power: supply: bq27xxx: Register power supply with devm

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Sun, Apr 30, 2017 at 08:27:24PM +0200, Paul Kocialkowski wrote:
> This uses the managed devices resources version of the
> power_supply_register_no_ws function to register the power supply.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  drivers/power/supply/bq27xxx_battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 6ef95442a918..be476e0bc85d 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1371,7 +1371,7 @@ int bq27xxx_battery_setup(struct bq27xxx_device_info *di)
>  	psy_desc->get_property = bq27xxx_battery_get_property;
>  	psy_desc->external_power_changed = bq27xxx_external_power_changed;
>  
> -	di->bat = power_supply_register_no_ws(di->dev, psy_desc, &psy_cfg);
> +	di->bat = devm_power_supply_register_no_ws(di->dev, psy_desc, &psy_cfg);
>  	if (IS_ERR(di->bat)) {
>  		dev_err(di->dev, "failed to register battery\n");
>  		return PTR_ERR(di->bat);

That does not make sense if bq27xxx_battery_teardown() still calls
power_supply_unregister().

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/5] power: supply: bq27xxx: Register power supply with devm Paul Kocialkowski <contact@paulk.fr> - 2017-04-30 20:30 +0200
  Re: [PATCH 2/5] power: supply: bq27xxx: Register power supply with  devm Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-01 13:00 +0200
    Re: [PATCH 2/5] power: supply: bq27xxx: Register power supply with  devm Paul Kocialkowski <contact@paulk.fr> - 2017-05-08 00:40 +0200

csiph-web