Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1633599

Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during swap out

From Johannes Weiner <hannes@cmpxchg.org>
Newsgroups linux.kernel
Subject Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during swap out
Date 2017-05-01 12:50 +0200
Message-ID <tCh3Y-7Zv-7@gated-at.bofh.it> (permalink)
References <tA8et-4Pu-17@gated-at.bofh.it> <tA8et-4Pu-15@gated-at.bofh.it> <tAKjL-4vc-9@gated-at.bofh.it> <tALSx-5DA-1@gated-at.bofh.it> <tB9Lc-4Zj-49@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 28, 2017 at 05:40:44PM +0900, Minchan Kim wrote:
> However, get_swap_page is ugly now. The caller should take care of
> failure and should retry after split. I hope get_swap_page includes
> split and retry logic in itself without reling on the caller.

I think this makes the interface terrible. It's an allocation function
to which you pass a reference object for size - and if the allocation
doesn't succeed it'll split your reference object to make it fit?

That's a nasty side effect for this function to have.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during swap out "Huang, Ying" <ying.huang@intel.com> - 2017-04-25 15:00 +0200
  Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during  swap out Minchan Kim <minchan@kernel.org> - 2017-04-27 07:40 +0200
    Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during swap out "Huang\, Ying" <ying.huang@intel.com> - 2017-04-27 09:20 +0200
      Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during  swap out Johannes Weiner <hannes@cmpxchg.org> - 2017-04-27 15:40 +0200
      Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during  swap out Minchan Kim <minchan@kernel.org> - 2017-04-28 10:50 +0200
        Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during swap out "Huang\, Ying" <ying.huang@intel.com> - 2017-04-28 14:30 +0200
          Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during  swap out Minchan Kim <minchan@kernel.org> - 2017-05-10 03:10 +0200
        Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during  swap out Johannes Weiner <hannes@cmpxchg.org> - 2017-05-01 12:50 +0200
          Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during  swap out Minchan Kim <minchan@kernel.org> - 2017-05-02 02:00 +0200
            Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during  swap out Johannes Weiner <hannes@cmpxchg.org> - 2017-05-10 16:00 +0200
              Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during  swap out Minchan Kim <minchan@kernel.org> - 2017-05-11 01:30 +0200
                Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during swap out "Huang\, Ying" <ying.huang@intel.com> - 2017-05-11 03:00 +0200
                Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during  swap out Minchan Kim <minchan@kernel.org> - 2017-05-11 06:40 +0200
                Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during  swap out Minchan Kim <minchan@kernel.org> - 2017-05-11 03:30 +0200
                Re: [PATCH -mm -v10 1/3] mm, THP, swap: Delay splitting THP during  swap out Johannes Weiner <hannes@cmpxchg.org> - 2017-05-11 12:50 +0200

csiph-web