Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1634547

Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings

From Mark Rutland <mark.rutland@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings
Date 2017-05-02 19:40 +0200
Message-ID <tCJWi-1h2-9@gated-at.bofh.it> (permalink)
References <tCr3j-5Nl-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi,

On Mon, May 01, 2017 at 02:26:22PM -0700, Matthias Kaehlcke wrote:
> diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
> index 5308d696311b..7db143689694 100644
> --- a/arch/arm64/include/asm/uaccess.h
> +++ b/arch/arm64/include/asm/uaccess.h
> @@ -302,7 +302,7 @@ do {									\
>  	"	.previous\n"						\
>  	_ASM_EXTABLE(1b, 3b)						\
>  	: "+r" (err)							\
> -	: "r" (x), "r" (addr), "i" (-EFAULT))
> +	: "r" ((__u64)x), "r" (addr), "i" (-EFAULT))
>  

For reference, do you have the warning for this case to hand?

In __put_user_err() we make __pu_val the same type as *ptr, then we
switch on sizeof(*ptr), and pass __pu_val to __put_user_asm(), as x.
For cases 1, 2, and 4, we use "%w" as the register template.

So I can't see why we'd  need this cast in __put_user_err().

I must be missing something.

Thanks,
Mark.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: Fix multiple 'asm-operand-widths' warnings Matthias Kaehlcke <mka@chromium.org> - 2017-05-01 23:30 +0200
  Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings Marc Zyngier <marc.zyngier@arm.com> - 2017-05-02 10:30 +0200
  Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings Mark Rutland <mark.rutland@arm.com> - 2017-05-02 12:30 +0200
    Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings Matthias Kaehlcke <mka@chromium.org> - 2017-05-02 19:30 +0200
  Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings Mark Rutland <mark.rutland@arm.com> - 2017-05-02 19:40 +0200
    Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings Matthias Kaehlcke <mka@chromium.org> - 2017-05-02 21:00 +0200
      Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings Mark Rutland <mark.rutland@arm.com> - 2017-05-03 13:00 +0200

csiph-web