Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1634236

Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings

Show all headers | View raw

On 01/05/17 22:26, Matthias Kaehlcke wrote:
> clang raises 'asm-operand-widths' warnings in inline assembly code when
> the size of an operand is < 64 bits and the operand width is unspecified.
> Most warnings are raised in macros, i.e. the datatype of the operand may
> vary. Forcing the use of an x register through the 'x' operand modifier
> would silence the warning however it involves the risk that for operands
> < 64 bits 'unused' bits may be assigned to 64-bit values (more details at
> http://lists.infradead.org/pipermail/linux-arm-kernel/2017-April/503816.html).
> Instead we cast the operand to 64 bits, which also forces the use of a
> x register, but without the unexpected behavior.
> 
> In gic_write_bpr1() use write_sysreg_s() to write the register. This
> aligns the functions with others in this header and fixes an
> 'asm-operand-widths' warning.
> 
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>  arch/arm64/include/asm/arch_gicv3.h  | 2 +-
>  arch/arm64/include/asm/barrier.h     | 2 +-
>  arch/arm64/include/asm/uaccess.h     | 2 +-
>  arch/arm64/kernel/armv8_deprecated.c | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/arch_gicv3.h b/arch/arm64/include/asm/arch_gicv3.h
> index f37e3a21f6e7..9092d612d8c2 100644
> --- a/arch/arm64/include/asm/arch_gicv3.h
> +++ b/arch/arm64/include/asm/arch_gicv3.h
> @@ -166,7 +166,7 @@ static inline void gic_write_sre(u32 val)
>  
>  static inline void gic_write_bpr1(u32 val)
>  {
> -	asm volatile("msr_s " __stringify(ICC_BPR1_EL1) ", %0" : : "r" (val));
> +	write_sysreg_s(val, ICC_BPR1_EL1);
>  }

For the GICv3 part:

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

	M.
-- 
Jazz is not dead. It just smells funny...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: Fix multiple 'asm-operand-widths' warnings Matthias Kaehlcke <mka@chromium.org> - 2017-05-01 23:30 +0200
  Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings Marc Zyngier <marc.zyngier@arm.com> - 2017-05-02 10:30 +0200
  Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings Mark Rutland <mark.rutland@arm.com> - 2017-05-02 12:30 +0200
    Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings Matthias Kaehlcke <mka@chromium.org> - 2017-05-02 19:30 +0200
  Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings Mark Rutland <mark.rutland@arm.com> - 2017-05-02 19:40 +0200
    Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings Matthias Kaehlcke <mka@chromium.org> - 2017-05-02 21:00 +0200
      Re: [PATCH] arm64: Fix multiple 'asm-operand-widths' warnings Mark Rutland <mark.rutland@arm.com> - 2017-05-03 13:00 +0200

csiph-web