Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1634180
| From | ivanhu <ivan.hu@canonical.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] efi/efi_test: drop useless kfree |
| Date | 2017-05-02 09:20 +0200 |
| Message-ID | <tCAgh-3oI-13@gated-at.bofh.it> (permalink) |
| References | <tBpGh-7H8-9@gated-at.bofh.it> <tBpGi-7H8-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 04/29/2017 09:42 AM, Geliang Tang wrote:
> Drop useless kfree when memdup_user() failed, since we have already
> called kfree in memdup_user().
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> drivers/firmware/efi/test/efi_test.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/efi/test/efi_test.c b/drivers/firmware/efi/test/efi_test.c
> index 08129b7..00332ae 100644
> --- a/drivers/firmware/efi/test/efi_test.c
> +++ b/drivers/firmware/efi/test/efi_test.c
> @@ -261,10 +261,8 @@ static long efi_runtime_set_variable(unsigned long arg)
> }
>
> data = memdup_user(setvariable.data, setvariable.data_size);
> - if (IS_ERR(data)) {
> - kfree(name);
You mean "name" or "data"?
Cheers,
Ivan
> + if (IS_ERR(data))
> return PTR_ERR(data);
> - }
>
> status = efi.set_variable(name, &vendor_guid,
> setvariable.attributes,
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] efi/efi_test: use memdup_user Geliang Tang <geliangtang@gmail.com> - 2017-04-29 03:50 +0200
[PATCH 2/2] efi/efi_test: drop useless kfree Geliang Tang <geliangtang@gmail.com> - 2017-04-29 03:50 +0200
Re: [PATCH 2/2] efi/efi_test: drop useless kfree ivanhu <ivan.hu@canonical.com> - 2017-05-02 09:20 +0200
Re: [PATCH 2/2] efi/efi_test: drop useless kfree Geliang Tang <geliangtang@gmail.com> - 2017-05-02 17:00 +0200
Re: [PATCH 1/2] efi/efi_test: use memdup_user Matt Fleming <matt@codeblueprint.co.uk> - 2017-05-05 23:00 +0200
Re: [PATCH 1/2] efi/efi_test: use memdup_user ivanhu <ivan.hu@canonical.com> - 2017-05-08 10:20 +0200
Re: [PATCH 1/2] efi/efi_test: use memdup_user Matt Fleming <matt@codeblueprint.co.uk> - 2017-05-10 12:40 +0200
csiph-web