[PATCH 1/2] efi/efi_test: use memdup_user

From	Geliang Tang <geliangtang@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] efi/efi_test: use memdup_user
Date	2017-04-29 03:50 +0200
Message-ID	<tBpGh-7H8-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Use memdup_user() helper instead of open-coding to simplify the code.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 drivers/firmware/efi/test/efi_test.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/firmware/efi/test/efi_test.c b/drivers/firmware/efi/test/efi_test.c
index 8cd578f..08129b7 100644
--- a/drivers/firmware/efi/test/efi_test.c
+++ b/drivers/firmware/efi/test/efi_test.c
@@ -71,18 +71,13 @@ copy_ucs2_from_user_len(efi_char16_t **dst, efi_char16_t __user *src,
 	if (!access_ok(VERIFY_READ, src, 1))
 		return -EFAULT;
 
-	buf = kmalloc(len, GFP_KERNEL);
-	if (!buf) {
+	buf = memdup_user(src, len);
+	if (IS_ERR(buf)) {
 		*dst = NULL;
-		return -ENOMEM;
+		return PTR_ERR(buf);
 	}
 	*dst = buf;
 
-	if (copy_from_user(*dst, src, len)) {
-		kfree(buf);
-		return -EFAULT;
-	}
-
 	return 0;
 }
 
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] efi/efi_test: use memdup_user Geliang Tang <geliangtang@gmail.com> - 2017-04-29 03:50 +0200
  [PATCH 2/2] efi/efi_test: drop useless kfree Geliang Tang <geliangtang@gmail.com> - 2017-04-29 03:50 +0200
    Re: [PATCH 2/2] efi/efi_test: drop useless kfree ivanhu <ivan.hu@canonical.com> - 2017-05-02 09:20 +0200
      Re: [PATCH 2/2] efi/efi_test: drop useless kfree Geliang Tang <geliangtang@gmail.com> - 2017-05-02 17:00 +0200
  Re: [PATCH 1/2] efi/efi_test: use memdup_user Matt Fleming <matt@codeblueprint.co.uk> - 2017-05-05 23:00 +0200
    Re: [PATCH 1/2] efi/efi_test: use memdup_user ivanhu <ivan.hu@canonical.com> - 2017-05-08 10:20 +0200
      Re: [PATCH 1/2] efi/efi_test: use memdup_user Matt Fleming <matt@codeblueprint.co.uk> - 2017-05-10 12:40 +0200

csiph-web