Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison()

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison()
Date	2017-04-29 02:20 +0200
Message-ID	<tBohb-6MR-1@gated-at.bofh.it> (permalink)
References	<tB0ye-7ca-9@gated-at.bofh.it> <tB0ye-7ca-7@gated-at.bofh.it> <tBohb-6MR-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 28, 2017 at 5:10 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Thu, Apr 27, 2017 at 3:57 PM, Toshi Kani <toshi.kani@hpe.com> wrote:
>> Badblocks are tracked at both region and device levels.
>> pmem_clear_poison() and nsio_rw_bytes() call nvdimm_clear_poison()
>> and then badblocks_clear() to clear badblocks at the device level.
>> However, it does not update badblocks at the region level, which
>> makes them inconsistent.
>>
>> Change nvdimm_clear_poison() to update backblocks at the region
>> level to keep them consistent.
>>
>> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
>> Cc: Dan Williams <dan.j.williams@intel.com>
>> Cc: Dave Jiang <dave.jiang@intel.com>
>> Cc: Vishal Verma <vishal.l.verma@intel.com>
>
> This looks good, and it seems we have a bug in the other location that
> does this in __nd_ioctl(). That other one is missing the
> "clear_err.cleared / 512" check. Can you respin this and define a
> common helper that both locations can call?

On second thought, I'll take this and spin my own cleanup / fix on top.

Thanks Toshi!

Thread

[PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() Toshi Kani <toshi.kani@hpe.com> - 2017-04-28 01:00 +0200
  Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() Dan Williams <dan.j.williams@intel.com> - 2017-04-29 02:20 +0200
    Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() Dan Williams <dan.j.williams@intel.com> - 2017-04-29 02:40 +0200
      Re: [PATCH 2/2] libnvdimm: clear region badblock in  nvdimm_clear_poison() "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-05-01 17:50 +0200
  Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() Dan Williams <dan.j.williams@intel.com> - 2017-04-29 02:20 +0200

csiph-web