Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1633214
| From | Dan Williams <dan.j.williams@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() |
| Date | 2017-04-29 02:40 +0200 |
| Message-ID | <tBoAx-6WJ-3@gated-at.bofh.it> (permalink) |
| References | <tB0ye-7ca-9@gated-at.bofh.it> <tB0ye-7ca-7@gated-at.bofh.it> <tBohb-6MR-3@gated-at.bofh.it> <tBohb-6MR-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Apr 28, 2017 at 5:12 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Fri, Apr 28, 2017 at 5:10 PM, Dan Williams <dan.j.williams@intel.com> wrote:
>> On Thu, Apr 27, 2017 at 3:57 PM, Toshi Kani <toshi.kani@hpe.com> wrote:
>>> Badblocks are tracked at both region and device levels.
>>> pmem_clear_poison() and nsio_rw_bytes() call nvdimm_clear_poison()
>>> and then badblocks_clear() to clear badblocks at the device level.
>>> However, it does not update badblocks at the region level, which
>>> makes them inconsistent.
>>>
>>> Change nvdimm_clear_poison() to update backblocks at the region
>>> level to keep them consistent.
>>>
>>> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
>>> Cc: Dan Williams <dan.j.williams@intel.com>
>>> Cc: Dave Jiang <dave.jiang@intel.com>
>>> Cc: Vishal Verma <vishal.l.verma@intel.com>
>>
>> This looks good, and it seems we have a bug in the other location that
>> does this in __nd_ioctl(). That other one is missing the
>> "clear_err.cleared / 512" check. Can you respin this and define a
>> common helper that both locations can call?
>
> On second thought, I'll take this and spin my own cleanup / fix on top.
>
> Thanks Toshi!
...and I need to drop it again because it causes this:
[ 106.974889] BUG: sleeping function called from invalid context at
kernel/locking/mutex.c:74
7
[ 106.977328] in_atomic(): 1, irqs_disabled(): 0, pid: 5584, name: dd
[ 106.978845] 1 lock held by dd/5584:
[ 106.979923] #0: (&bdev->bd_mutex){+.+.+.}, at:
[<ffffffff812f4937>] __blkdev_put+0x47/0x3
70
[ 106.982221] CPU: 29 PID: 5584 Comm: dd Tainted: G O
4.11.0-rc4+ #105
[ 106.984329] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
BIOS 1.9.3-1.fc25 04/01/
2014
[ 106.986638] Call Trace:
[ 106.987530] dump_stack+0x86/0xc3
[ 106.988555] ___might_sleep+0x17d/0x250
[ 106.989650] __might_sleep+0x4a/0x80
[ 106.990718] __mutex_lock+0x58/0x980
[ 106.991788] ? nvdimm_bus_lock+0x21/0x30 [libnvdimm]
[ 106.993059] ? _raw_spin_unlock+0x27/0x40
[ 106.994181] ? debug_lockdep_rcu_enabled+0x1d/0x20
[ 106.995430] mutex_lock_nested+0x1b/0x20
[ 106.996552] nvdimm_bus_lock+0x21/0x30 [libnvdimm]
[ 106.997804] nvdimm_clear_poison+0x11a/0x150 [libnvdimm]
[ 106.999138] nsio_rw_bytes+0x18f/0x280 [libnvdimm]
[ 107.000390] btt_write_pg+0x1d4/0x3c0 [nd_btt]
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() Toshi Kani <toshi.kani@hpe.com> - 2017-04-28 01:00 +0200
Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() Dan Williams <dan.j.williams@intel.com> - 2017-04-29 02:20 +0200
Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() Dan Williams <dan.j.williams@intel.com> - 2017-04-29 02:40 +0200
Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-05-01 17:50 +0200
Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() Dan Williams <dan.j.williams@intel.com> - 2017-04-29 02:20 +0200
csiph-web