Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1632831

Re: [PATCH v4] staging: ks7010: fix block comment style

Show all headers | View raw

On Fri, Apr 28, 2017 at 12:35:55PM +0200, Ilia Sergachev wrote:
> Checkpatch was showing:
> WARNING: Block comments use a trailing */ on a separate line.
> 
> Move trailing */ to a separate line.
> 
> Signed-off-by: Ilia Sergachev <ilia.sergachev@unibas.ch>
> ---
> Changes for v4:
>   - remove one trailing whitespace in the last hunk, 
>     which was corrupting the patch

Nope, the whole thing still doesn't apply:

checking file drivers/staging/ks7010/ks_wlan_net.c
Hunk #1 FAILED at 230.
Hunk #2 FAILED at 343.
Hunk #3 FAILED at 1137.
Hunk #4 FAILED at 1189.
Hunk #5 FAILED at 1225.
Hunk #6 FAILED at 1497.
Hunk #7 FAILED at 1569.
Hunk #8 FAILED at 1596.
Hunk #9 FAILED at 1970.
Hunk #10 FAILED at 2105.
Hunk #11 FAILED at 3351.
11 out of 11 hunks FAILED

What tree/branch are you making this patch against?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c Ilia Sergachev <ilia.sergachev@unibas.ch> - 2017-04-25 23:10 +0200
  Re: [PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c "Tobin C. Harding" <me@tobin.cc> - 2017-04-26 05:30 +0200
  [PATCH v2] Staging: ks7010: style fix Ilia Sergachev <ilia.sergachev@unibas.ch> - 2017-04-26 10:30 +0200
    Re: [PATCH v2] Staging: ks7010: style fix Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-26 10:40 +0200
  [PATCH v2] Staging: ks7010: style fix Ilia Sergachev <ilia.sergachev@unibas.ch> - 2017-04-26 10:50 +0200
    Re: [PATCH v2] Staging: ks7010: style fix "Tobin C. Harding" <me@tobin.cc> - 2017-04-26 12:40 +0200
      Re: [PATCH v2] Staging: ks7010: style fix Dan Carpenter <dan.carpenter@oracle.com> - 2017-04-26 12:50 +0200
  [PATCH v3] staging: ks7010: fix block comment style Ilia Sergachev <ilia.sergachev@unibas.ch> - 2017-04-26 13:10 +0200
    Re: [PATCH v3] staging: ks7010: fix block comment style "Tobin C. Harding" <me@tobin.cc> - 2017-04-27 01:00 +0200
    Re: [PATCH v3] staging: ks7010: fix block comment style Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 11:50 +0200
  [PATCH v4] staging: ks7010: fix block comment style Ilia Sergachev <ilia.sergachev@unibas.ch> - 2017-04-28 12:40 +0200
    Re: [PATCH v4] staging: ks7010: fix block comment style Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 14:30 +0200
      Re: [PATCH v4] staging: ks7010: fix block comment style Ilia Sergachev <ilia.sergachev@unibas.ch> - 2017-04-28 15:10 +0200
        Re: [PATCH v4] staging: ks7010: fix block comment style "Tobin C. Harding" <me@tobin.cc> - 2017-04-30 11:20 +0200

csiph-web