Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1631376
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] Staging: ks7010: style fix |
| Date | 2017-04-26 12:50 +0200 |
| Message-ID | <tAsGe-15h-21@gated-at.bofh.it> (permalink) |
| References | <tAfSG-1qD-25@gated-at.bofh.it> <tAqO5-8hi-11@gated-at.bofh.it> <tAswx-11B-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Apr 26, 2017 at 08:37:56PM +1000, Tobin C. Harding wrote: > On Wed, Apr 26, 2017 at 10:38:54AM +0200, Ilia Sergachev wrote: > > Fix the style of block comments. > > Move trailing */ to a separate line. > > Checkpatch was showing: > > WARNING: Block comments use a trailing */ on a separate line. > > You are doing well Ilia. A few nitpicks > > - Your first subject was better (excluding the filname) :) it was more > descriptive. Yeah. This subject is bad. > > - staging has a small 's'. You can verify with; > $ git log --pretty=oneline drivers/staging/ks7010/ks_wlan_net.c Nah.. It can go either way. No one cares. regards, dan carpenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c Ilia Sergachev <ilia.sergachev@unibas.ch> - 2017-04-25 23:10 +0200
Re: [PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c "Tobin C. Harding" <me@tobin.cc> - 2017-04-26 05:30 +0200
[PATCH v2] Staging: ks7010: style fix Ilia Sergachev <ilia.sergachev@unibas.ch> - 2017-04-26 10:30 +0200
Re: [PATCH v2] Staging: ks7010: style fix Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-26 10:40 +0200
[PATCH v2] Staging: ks7010: style fix Ilia Sergachev <ilia.sergachev@unibas.ch> - 2017-04-26 10:50 +0200
Re: [PATCH v2] Staging: ks7010: style fix "Tobin C. Harding" <me@tobin.cc> - 2017-04-26 12:40 +0200
Re: [PATCH v2] Staging: ks7010: style fix Dan Carpenter <dan.carpenter@oracle.com> - 2017-04-26 12:50 +0200
[PATCH v3] staging: ks7010: fix block comment style Ilia Sergachev <ilia.sergachev@unibas.ch> - 2017-04-26 13:10 +0200
Re: [PATCH v3] staging: ks7010: fix block comment style "Tobin C. Harding" <me@tobin.cc> - 2017-04-27 01:00 +0200
Re: [PATCH v3] staging: ks7010: fix block comment style Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 11:50 +0200
[PATCH v4] staging: ks7010: fix block comment style Ilia Sergachev <ilia.sergachev@unibas.ch> - 2017-04-28 12:40 +0200
Re: [PATCH v4] staging: ks7010: fix block comment style Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-28 14:30 +0200
Re: [PATCH v4] staging: ks7010: fix block comment style Ilia Sergachev <ilia.sergachev@unibas.ch> - 2017-04-28 15:10 +0200
Re: [PATCH v4] staging: ks7010: fix block comment style "Tobin C. Harding" <me@tobin.cc> - 2017-04-30 11:20 +0200
csiph-web