Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1633311

[PATCH 1/1] staging: comedi: use __func__ instead of hardcoded function name

Path csiph.com!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Dhiru Kholia <dhiru.kholia@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 1/1] staging: comedi: use __func__ instead of hardcoded function name
Date Sat, 29 Apr 2017 18:50:01 +0200
Message-ID <tBDJf-c0-9@gated-at.bofh.it> (permalink)
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=2il5YjPDr7bkoWZDs5aADigaRDjkf7Pp/bOwFcM0+Ng=; b=gHAVUd2Su9/N8J+z7WUbT0mZe2xqgw7y5bTLl7yafU2+jKcSbytbLHkbUVMS9Dco4k 24nal3jxXPcOd9Sb+pnEnQwnUj4SvswKLA2lkZJocAkJwMOhqtdoQBZV1MbwzjEVhdk0 VKF9reyhK7r8NWFSD7Cwc4TDjAweyZ5/Gb6YS5Zjsm1F/Ekyh9TSEpPwBIvig4aA+IBV FzwvTm7yCd6cB20iwYCl1gpF3XxpO55Yle8b7vVFAnN7yW+QLgK3Nngd4l5Jh61Nu0Mw It1WlWr8SFAVvPMRkUI4ToOoNSR1TvK5C9SmHkDcqFu9Ucy2fVXnlsHclPz6e+WnMByU aFUw==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2il5YjPDr7bkoWZDs5aADigaRDjkf7Pp/bOwFcM0+Ng=; b=N3CL4woQpTiI4/edNO3dLk/GaOb3lGbikR5wng2ALpVam10rjY2NKOTru6C3bnVtvR SH7+NzjUbtQMUo1/oYdfqGL3Az+2ye6aVHkM/2+eq2dAe3CYk+BKGYf/XdEhSSJIzKmf iU0FeTvOFDCoJoe47Czv0hkLtXz0M59RV2RS2c8EgPQU8oQ1ZiEk+xpyJG2WOo6DNIwT AeEnmbWM6sQl1nExRYyPTFzFh+z41uk7o+yGT2JzonVmhyZfw9IlBpFt8+G1OeODhIFl i2eGS6MUighVTKsrmYF3jSJDYVfkbA+cN+zj03+tiSz+D24xZPDde37GUbnP+KFC7E/k QOlw==
X-Gm-Message-State AN3rC/67dlpYfPOZS1/2hDq47+gQ3zKZIBqDcTT18wGBk4MK7+1I5Ag7 RLZMPhG3HvBeAL1iFHM=
X-Received by 10.98.147.26 with SMTP id b26mr17874171pfe.65.1493484475346; Sat, 29 Apr 2017 09:47:55 -0700 (PDT)
X-Mailer git-send-email 2.7.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 24
Organization linux.* mail to news gateway
X-Original-Cc Ian Abbott <abbotti@mev.co.uk>, H Hartley Sweeten <hsweeten@visionengravers.com>
X-Original-Date Sat, 29 Apr 2017 22:17:48 +0530
X-Original-Message-ID <1493484468-25699-1-git-send-email-dhiru.kholia@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1633311

Show key headers only | View raw


This coding style issue was found by checkpatch.pl script. Using
__func__ instead of hardcoded function name should help in future
refactoring of this code.

Signed-off-by: Dhiru Kholia <dhiru.kholia@gmail.com>
---
 drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index 802f51e..ea194aa 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -248,7 +248,7 @@ static irqreturn_t daqp_interrupt(int irq, void *dev_id)
 
 	if (loop_limit <= 0) {
 		dev_warn(dev->class_dev,
-			 "loop_limit reached in daqp_interrupt()\n");
+			 "loop_limit reached in %s()\n", __func__);
 		s->async->events |= COMEDI_CB_ERROR;
 	}
 
-- 
2.7.4

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH 1/1] staging: comedi: use __func__ instead of hardcoded function name Dhiru Kholia <dhiru.kholia@gmail.com> - 2017-04-29 18:50 +0200
  Re: [PATCH 1/1] staging: comedi: use __func__ instead of hardcoded  function name Joe Perches <joe@perches.com> - 2017-04-29 19:30 +0200
    Re: [PATCH 1/1] staging: comedi: use __func__ instead of hardcoded  function name Dhiru Kholia <dhiru.kholia@gmail.com> - 2017-04-30 12:20 +0200

csiph-web