Re: [PATCH 1/1] staging: comedi: use func instead of hardcoded function name

From	Dhiru Kholia <dhiru.kholia@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] staging: comedi: use __func__ instead of hardcoded function name
Date	2017-04-30 12:20 +0200
Message-ID	<tBU7o-1Wa-13@gated-at.bofh.it> (permalink)
References	<tBDJf-c0-9@gated-at.bofh.it> <tBElX-DO-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Apr 29, 2017 at 10:21:33AM -0700, Joe Perches wrote:
> On Sat, 2017-04-29 at 22:17 +0530, Dhiru Kholia wrote:
> > This coding style issue was found by checkpatch.pl script. Using
> > __func__ instead of hardcoded function name should help in future
> > refactoring of this code.
> > 
> >  	if (loop_limit <= 0) {
> >  		dev_warn(dev->class_dev,
> > -			 "loop_limit reached in daqp_interrupt()\n");
> > +			 "loop_limit reached in %s()\n", __func__);
> 
> More common would be:
> 		dev_warn(dev->class_dev, "%s: loop limit reached\n", __func__);

Thanks for the feedback, Joe. I have sent out a v2 of this patch with
this suggestion applied.
 
> It also seems that the loop_limit test, a loop count,
> is sensitive on the cpu frequency and perhaps should
> be some timer based limit instead.

I am not familiar with this code at all. I am doing this patch as part
of "The Eudyptula Challenge" (http://eudyptula-challenge.org/).

Thanks,
Dhiru

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] staging: comedi: use __func__ instead of hardcoded function name Dhiru Kholia <dhiru.kholia@gmail.com> - 2017-04-29 18:50 +0200
  Re: [PATCH 1/1] staging: comedi: use __func__ instead of hardcoded  function name Joe Perches <joe@perches.com> - 2017-04-29 19:30 +0200
    Re: [PATCH 1/1] staging: comedi: use __func__ instead of hardcoded  function name Dhiru Kholia <dhiru.kholia@gmail.com> - 2017-04-30 12:20 +0200

csiph-web